github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-08-16 15:09:35 -05:00
Code Issues 2.4k Packages Projects Releases 129 Wiki Activity

[PR #6746] [MERGED] chore: Create common UI elements for VaultItemScreen #19592

New Issue
Closed
opened 2026-04-15 03:55:07 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-15 03:55:07 -05:00
Owner
Copy Link
Copy Source

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/6746
Author: @david-livefront
Created: 3/31/2026
Status: ✅ Merged
Merged: 3/31/2026
Merged by: @david-livefront

Base: main ← Head: commonize-view-item

📝 Commits (1)

  • 7143952 Create common UI elements for VaultItemScreen

📊 Changes

15 files changed (+454 additions, -836 deletions)

View changed files

📝 app/src/main/kotlin/com/x8bit/bitwarden/ui/vault/feature/item/VaultItemCardContent.kt (+21 -154)
📝 app/src/main/kotlin/com/x8bit/bitwarden/ui/vault/feature/item/VaultItemIdentityContent.kt (+21 -144)
📝 app/src/main/kotlin/com/x8bit/bitwarden/ui/vault/feature/item/VaultItemLoginContent.kt (+22 -177)
📝 app/src/main/kotlin/com/x8bit/bitwarden/ui/vault/feature/item/VaultItemSecureNoteContent.kt (+22 -157)
📝 app/src/main/kotlin/com/x8bit/bitwarden/ui/vault/feature/item/VaultItemSshKeyContent.kt (+21 -153)
📝 app/src/main/kotlin/com/x8bit/bitwarden/ui/vault/feature/item/VaultItemViewModel.kt (+14 -10)
📝 app/src/main/kotlin/com/x8bit/bitwarden/ui/vault/feature/item/component/VaultItemAttachment.kt (+3 -2)
➕ app/src/main/kotlin/com/x8bit/bitwarden/ui/vault/feature/item/component/VaultItemAttachments.kt (+61 -0)
➕ app/src/main/kotlin/com/x8bit/bitwarden/ui/vault/feature/item/component/VaultItemCustomFields.kt (+59 -0)
➕ app/src/main/kotlin/com/x8bit/bitwarden/ui/vault/feature/item/component/VaultItemHistory.kt (+97 -0)
➕ app/src/main/kotlin/com/x8bit/bitwarden/ui/vault/feature/item/component/VaultItemNotes.kt (+69 -0)
📝 app/src/main/kotlin/com/x8bit/bitwarden/ui/vault/feature/item/util/CipherViewExtensions.kt (+14 -9)
📝 app/src/test/kotlin/com/x8bit/bitwarden/ui/vault/feature/item/VaultItemScreenTest.kt (+22 -22)
📝 app/src/test/kotlin/com/x8bit/bitwarden/ui/vault/feature/item/VaultItemViewModelTest.kt (+4 -4)
📝 app/src/test/kotlin/com/x8bit/bitwarden/ui/vault/feature/item/util/VaultItemTestUtil.kt (+4 -4)

📄 Description

🎟️ Tracking

N/A

📔 Objective

This PR creates several common reusable UI elements for the VaultItemScreen to ensure a consistent UI.

This idea was sparked because there was recently a bug on the Identity UI that did not exist in the other cipher types. Making the code common will help up keep everything consistent.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/6746 **Author:** [@david-livefront](https://github.com/david-livefront) **Created:** 3/31/2026 **Status:** ✅ Merged **Merged:** 3/31/2026 **Merged by:** [@david-livefront](https://github.com/david-livefront) **Base:** `main` ← **Head:** `commonize-view-item` --- ### 📝 Commits (1) - [`7143952`](https://github.com/bitwarden/android/commit/714395226019d67a053a2d2af0653aefd3c59d92) Create common UI elements for VaultItemScreen ### 📊 Changes **15 files changed** (+454 additions, -836 deletions) <details> <summary>View changed files</summary> 📝 `app/src/main/kotlin/com/x8bit/bitwarden/ui/vault/feature/item/VaultItemCardContent.kt` (+21 -154) 📝 `app/src/main/kotlin/com/x8bit/bitwarden/ui/vault/feature/item/VaultItemIdentityContent.kt` (+21 -144) 📝 `app/src/main/kotlin/com/x8bit/bitwarden/ui/vault/feature/item/VaultItemLoginContent.kt` (+22 -177) 📝 `app/src/main/kotlin/com/x8bit/bitwarden/ui/vault/feature/item/VaultItemSecureNoteContent.kt` (+22 -157) 📝 `app/src/main/kotlin/com/x8bit/bitwarden/ui/vault/feature/item/VaultItemSshKeyContent.kt` (+21 -153) 📝 `app/src/main/kotlin/com/x8bit/bitwarden/ui/vault/feature/item/VaultItemViewModel.kt` (+14 -10) 📝 `app/src/main/kotlin/com/x8bit/bitwarden/ui/vault/feature/item/component/VaultItemAttachment.kt` (+3 -2) ➕ `app/src/main/kotlin/com/x8bit/bitwarden/ui/vault/feature/item/component/VaultItemAttachments.kt` (+61 -0) ➕ `app/src/main/kotlin/com/x8bit/bitwarden/ui/vault/feature/item/component/VaultItemCustomFields.kt` (+59 -0) ➕ `app/src/main/kotlin/com/x8bit/bitwarden/ui/vault/feature/item/component/VaultItemHistory.kt` (+97 -0) ➕ `app/src/main/kotlin/com/x8bit/bitwarden/ui/vault/feature/item/component/VaultItemNotes.kt` (+69 -0) 📝 `app/src/main/kotlin/com/x8bit/bitwarden/ui/vault/feature/item/util/CipherViewExtensions.kt` (+14 -9) 📝 `app/src/test/kotlin/com/x8bit/bitwarden/ui/vault/feature/item/VaultItemScreenTest.kt` (+22 -22) 📝 `app/src/test/kotlin/com/x8bit/bitwarden/ui/vault/feature/item/VaultItemViewModelTest.kt` (+4 -4) 📝 `app/src/test/kotlin/com/x8bit/bitwarden/ui/vault/feature/item/util/VaultItemTestUtil.kt` (+4 -4) </details> ### 📄 Description ## 🎟️ Tracking N/A ## 📔 Objective This PR creates several common reusable UI elements for the `VaultItemScreen` to ensure a consistent UI. This idea was sparked because there was recently a bug on the Identity UI that did not exist in the other cipher types. Making the code common will help up keep everything consistent. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-15 03:55:07 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No labels pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
GiteaMirror ninjasurge (Kaehlen Rog)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#19592