github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-05-07 00:09:31 -05:00
Code Issues 1.1k Packages Projects Releases 122 Wiki Activity

[PR #6727] [MERGED] PM-34193: bug: Unlock vault from Never-Lock should be on io thread #19577

New Issue
Closed
opened 2026-04-15 03:54:35 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-15 03:54:35 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/6727
Author: @david-livefront
Created: 3/27/2026
Status: ✅ Merged
Merged: 3/27/2026
Merged by: @mpbw2

Base: release/2026.3-rc49 ← Head: PM-34193-never-lock-io-dispatcher

📝 Commits (1)

  • 35af5a8 PM-34193: Unlock vault from Never-Lock should be on io thread

📊 Changes

1 file changed (+2 additions, -1 deletions)

View changed files

📝 app/src/main/kotlin/com/x8bit/bitwarden/data/vault/manager/VaultLockManagerImpl.kt (+2 -1)

📄 Description

🎟️ Tracking

PM-34193

📔 Objective

This PR addresses a bug with Never timeout value. We are now observing changes to the timeout type via the io dispatcher to ensure that the SDK cannot deadlock when calling back. This was a problem when we used the unconfined dispatcher. We are going to continue to investigate why this is happening, since using the unconfined dispatcher should not be a problem here.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/6727 **Author:** [@david-livefront](https://github.com/david-livefront) **Created:** 3/27/2026 **Status:** ✅ Merged **Merged:** 3/27/2026 **Merged by:** [@mpbw2](https://github.com/mpbw2) **Base:** `release/2026.3-rc49` ← **Head:** `PM-34193-never-lock-io-dispatcher` --- ### 📝 Commits (1) - [`35af5a8`](https://github.com/bitwarden/android/commit/35af5a854ec54995b5e72156066c9e14497a92b0) PM-34193: Unlock vault from Never-Lock should be on io thread ### 📊 Changes **1 file changed** (+2 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `app/src/main/kotlin/com/x8bit/bitwarden/data/vault/manager/VaultLockManagerImpl.kt` (+2 -1) </details> ### 📄 Description ## 🎟️ Tracking [PM-34193](https://bitwarden.atlassian.net/browse/PM-34193) ## 📔 Objective This PR addresses a bug with `Never` timeout value. We are now observing changes to the timeout type via the `io` dispatcher to ensure that the SDK cannot deadlock when calling back. This was a problem when we used the `unconfined` dispatcher. We are going to continue to investigate why this is happening, since using the `unconfined` dispatcher should not be a problem here. [PM-34193]: https://bitwarden.atlassian.net/browse/PM-34193?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-15 03:54:35 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#19577
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?