github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-05-07 19:39:41 -05:00
Code Issues 1.1k Packages Projects Releases 122 Wiki Activity

[PR #6617] [MERGED] PM-26059: Remove CipherKeyEncryption feature flag #19475

New Issue
Closed
opened 2026-04-15 03:51:20 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-15 03:51:20 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/6617
Author: @david-livefront
Created: 3/5/2026
Status: ✅ Merged
Merged: 3/9/2026
Merged by: @david-livefront

Base: main ← Head: PM-26059-remove-cipher-key-encryption-flag

📝 Commits (1)

  • 0290986 PM-26059: Remove CipherKeyEncryption feature flag

📊 Changes

7 files changed (+10 additions, -34 deletions)

View changed files

📝 app/src/main/kotlin/com/x8bit/bitwarden/data/platform/manager/FeatureFlagManagerImpl.kt (+7 -12)
📝 app/src/test/kotlin/com/x8bit/bitwarden/data/platform/manager/FeatureFlagManagerTest.kt (+1 -1)
📝 app/src/test/kotlin/com/x8bit/bitwarden/ui/platform/feature/debugmenu/DebugMenuViewModelTest.kt (+2 -4)
📝 core/src/main/kotlin/com/bitwarden/core/data/manager/model/FlagKey.kt (+0 -9)
📝 core/src/test/kotlin/com/bitwarden/core/data/manager/model/FlagKeyTest.kt (+0 -5)
📝 ui/src/main/kotlin/com/bitwarden/ui/platform/components/debug/FeatureFlagListItems.kt (+0 -2)
📝 ui/src/main/res/values/strings_non_localized.xml (+0 -1)

📄 Description

🎟️ Tracking

PM-26059

📔 Objective

This PR removes the CipherKeyEncryption feature flag from the app.

Note that there is still a server version check for this feature to ensure older servers that do not support the feature do not receive updated ciphers.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/6617 **Author:** [@david-livefront](https://github.com/david-livefront) **Created:** 3/5/2026 **Status:** ✅ Merged **Merged:** 3/9/2026 **Merged by:** [@david-livefront](https://github.com/david-livefront) **Base:** `main` ← **Head:** `PM-26059-remove-cipher-key-encryption-flag` --- ### 📝 Commits (1) - [`0290986`](https://github.com/bitwarden/android/commit/0290986e952d91aa29584643deda02a9e175ee99) PM-26059: Remove CipherKeyEncryption feature flag ### 📊 Changes **7 files changed** (+10 additions, -34 deletions) <details> <summary>View changed files</summary> 📝 `app/src/main/kotlin/com/x8bit/bitwarden/data/platform/manager/FeatureFlagManagerImpl.kt` (+7 -12) 📝 `app/src/test/kotlin/com/x8bit/bitwarden/data/platform/manager/FeatureFlagManagerTest.kt` (+1 -1) 📝 `app/src/test/kotlin/com/x8bit/bitwarden/ui/platform/feature/debugmenu/DebugMenuViewModelTest.kt` (+2 -4) 📝 `core/src/main/kotlin/com/bitwarden/core/data/manager/model/FlagKey.kt` (+0 -9) 📝 `core/src/test/kotlin/com/bitwarden/core/data/manager/model/FlagKeyTest.kt` (+0 -5) 📝 `ui/src/main/kotlin/com/bitwarden/ui/platform/components/debug/FeatureFlagListItems.kt` (+0 -2) 📝 `ui/src/main/res/values/strings_non_localized.xml` (+0 -1) </details> ### 📄 Description ## 🎟️ Tracking [PM-26059](https://bitwarden.atlassian.net/browse/PM-26059) ## 📔 Objective This PR removes the `CipherKeyEncryption` feature flag from the app. Note that there is still a server version check for this feature to ensure older servers that do not support the feature do not receive updated ciphers. [PM-26059]: https://bitwarden.atlassian.net/browse/PM-26059?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-15 03:51:20 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#19475
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?