github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-05-06 07:48:22 -05:00
Code Issues 1.1k Packages Projects Releases 122 Wiki Activity

[PR #6534] [MERGED] Add implementing-android-code skill and deduplicate CLAUDE.md #19405

New Issue
Closed
opened 2026-04-15 03:48:14 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-15 03:48:14 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/6534
Author: @SaintPatrck
Created: 2/13/2026
Status: ✅ Merged
Merged: 2/24/2026
Merged by: @SaintPatrck

Base: main ← Head: claude/implementing-android-code

📝 Commits (8)

  • 66f36a6 Add implementing-android-code skill with templates and deduplicate CLAUDE.md
  • 29967b9 Fix cross-template inconsistency in ViewModel template
  • 356534f Fix remaining template inconsistencies in implementing-android-code skill
  • 251530a Update .claude/skills/implementing-android-code/templates.md
  • cbaa011 Fix remaining review comments in implementing-android-code skill
  • 51bcf14 Add marketplace metadata to implementing-android-code skill
  • 0252cac Address code review feedback on implementing-android-code skill
  • 4a4b200 Removed paddingValues

📊 Changes

6 files changed (+1324 additions, -34 deletions)

View changed files

📝 .claude/CLAUDE.md (+39 -34)
➕ .claude/skills/implementing-android-code/CHANGELOG.md (+23 -0)
➕ .claude/skills/implementing-android-code/CONTRIBUTING.md (+44 -0)
➕ .claude/skills/implementing-android-code/README.md (+77 -0)
➕ .claude/skills/implementing-android-code/SKILL.md (+497 -0)
➕ .claude/skills/implementing-android-code/templates.md (+644 -0)

📄 Description

🎟️ Tracking

N/A — Internal Claude Code skill and configuration improvement.

📔 Objective

Add a new implementing-android-code Claude Code skill with supporting templates, and clean up duplication in .claude/CLAUDE.md.

New skill (.claude/skills/implementing-android-code/):

  • SKILL.md — Quick reference for Bitwarden-specific patterns: ViewModel SAE, type-safe navigation, Screen/Compose, data layer, security (encrypted storage, input validation), testing, and Clock injection
  • templates.md — Copy-pasteable code templates derived from actual codebase examples (LoginViewModel, LoginNavigation, LoginScreen, GeneratorRepositoryModule, AuthDiskModule, GeneratorViewModelTest)

CLAUDE.md changes:

  • Added Codebase Discovery section with search commands for finding ViewModels, navigation files, Hilt modules, repositories, and UI components
  • Added implementing-android-code skill reference in Development Guide
  • Deduplicated Anti-Patterns DO/DON'T items already covered by Key Principles
  • Removed duplicate DataState definition (Key Concepts vs Data Models)
  • Reduced docs/ARCHITECTURE.md references from 5 to 2
  • Consolidated References section (removed skills list that's auto-discoverable, compacted external links)

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/6534 **Author:** [@SaintPatrck](https://github.com/SaintPatrck) **Created:** 2/13/2026 **Status:** ✅ Merged **Merged:** 2/24/2026 **Merged by:** [@SaintPatrck](https://github.com/SaintPatrck) **Base:** `main` ← **Head:** `claude/implementing-android-code` --- ### 📝 Commits (8) - [`66f36a6`](https://github.com/bitwarden/android/commit/66f36a612c39fad703157b1c6389933b4f003085) Add implementing-android-code skill with templates and deduplicate CLAUDE.md - [`29967b9`](https://github.com/bitwarden/android/commit/29967b9653d51d34a8e638f27eb278382103c0ce) Fix cross-template inconsistency in ViewModel template - [`356534f`](https://github.com/bitwarden/android/commit/356534fe34ebde241f1bf2d687f85d31ab61699d) Fix remaining template inconsistencies in implementing-android-code skill - [`251530a`](https://github.com/bitwarden/android/commit/251530a7c06bae29fde2c508ab5cd24e6b764ceb) Update .claude/skills/implementing-android-code/templates.md - [`cbaa011`](https://github.com/bitwarden/android/commit/cbaa0119175ae6cdc418d0aef50c01cd218713d4) Fix remaining review comments in implementing-android-code skill - [`51bcf14`](https://github.com/bitwarden/android/commit/51bcf148755567474bb397ab269d097e9dfee163) Add marketplace metadata to implementing-android-code skill - [`0252cac`](https://github.com/bitwarden/android/commit/0252cac9dc3bcbb625182c731aeca5ea088125d7) Address code review feedback on implementing-android-code skill - [`4a4b200`](https://github.com/bitwarden/android/commit/4a4b2001e47d15888cea1d1db069718333063090) Removed paddingValues ### 📊 Changes **6 files changed** (+1324 additions, -34 deletions) <details> <summary>View changed files</summary> 📝 `.claude/CLAUDE.md` (+39 -34) ➕ `.claude/skills/implementing-android-code/CHANGELOG.md` (+23 -0) ➕ `.claude/skills/implementing-android-code/CONTRIBUTING.md` (+44 -0) ➕ `.claude/skills/implementing-android-code/README.md` (+77 -0) ➕ `.claude/skills/implementing-android-code/SKILL.md` (+497 -0) ➕ `.claude/skills/implementing-android-code/templates.md` (+644 -0) </details> ### 📄 Description ## 🎟️ Tracking N/A — Internal Claude Code skill and configuration improvement. ## 📔 Objective Add a new `implementing-android-code` Claude Code skill with supporting templates, and clean up duplication in `.claude/CLAUDE.md`. **New skill** (`.claude/skills/implementing-android-code/`): - `SKILL.md` — Quick reference for Bitwarden-specific patterns: ViewModel SAE, type-safe navigation, Screen/Compose, data layer, security (encrypted storage, input validation), testing, and Clock injection - `templates.md` — Copy-pasteable code templates derived from actual codebase examples (LoginViewModel, LoginNavigation, LoginScreen, GeneratorRepositoryModule, AuthDiskModule, GeneratorViewModelTest) **CLAUDE.md changes**: - Added **Codebase Discovery** section with search commands for finding ViewModels, navigation files, Hilt modules, repositories, and UI components - Added `implementing-android-code` skill reference in Development Guide - Deduplicated Anti-Patterns DO/DON'T items already covered by Key Principles - Removed duplicate DataState definition (Key Concepts vs Data Models) - Reduced `docs/ARCHITECTURE.md` references from 5 to 2 - Consolidated References section (removed skills list that's auto-discoverable, compacted external links) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-15 03:48:14 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#19405
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?