github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-06-10 00:28:29 -05:00
Code Issues 2.2k Packages Projects Releases 127 Wiki Activity

[PR #6508] [MERGED] [PM-31835] feat: add generator copy password field on send #19383

New Issue
Closed
opened 2026-04-15 03:47:33 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-15 03:47:33 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/6508
Author: @aj-rosado
Created: 2/10/2026
Status: ✅ Merged
Merged: 2/19/2026
Merged by: @aj-rosado

Base: main ← Head: PM-31835/add-generator-copy-password-field-on-send

📝 Commits (10+)

  • b6b7002 Added new UI for the Email verification on sends
  • 5dd79bf Merge branch 'main' into PM-31614/update-add-edit-send-ui-email-auth
  • 2606d6b Added copy and generator option to the new AuthTypeChooser password field
  • bc3b881 Merge branch 'main' into PM-31614/update-add-edit-send-ui-email-auth
  • 042a104 Merge branch 'PM-31614/update-add-edit-send-ui-email-auth' into PM-31835/add-generator-copy-password-field-on-send
  • 107ac9f addressed PR comments
  • 9b0b6af Addressed missing ImmutableList calls and fixed tests
  • c91306b Merge branch 'main' into PM-31614/update-add-edit-send-ui-email-auth
  • b3053e4 fixed SyncServiceTest
  • c813498 Revert "fixed SyncServiceTest"

📊 Changes

4 files changed (+236 additions, -11 deletions)

View changed files

📝 app/src/main/kotlin/com/x8bit/bitwarden/ui/tools/feature/send/addedit/AddEditSendContent.kt (+13 -9)
📝 app/src/main/kotlin/com/x8bit/bitwarden/ui/tools/feature/send/addedit/components/AddEditSendAuthTypeChooser.kt (+53 -1)
📝 app/src/main/kotlin/com/x8bit/bitwarden/ui/tools/feature/send/addedit/util/AddEditSendStateExtensions.kt (+4 -1)
📝 app/src/test/kotlin/com/x8bit/bitwarden/ui/tools/feature/send/addedit/AddEditSendScreenTest.kt (+166 -0)

📄 Description

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-31835

📔 Objective

Add copy and generator button to the password field on the new send's password AuthType

📸 Screenshots

Screenshot_1770736912

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/6508 **Author:** [@aj-rosado](https://github.com/aj-rosado) **Created:** 2/10/2026 **Status:** ✅ Merged **Merged:** 2/19/2026 **Merged by:** [@aj-rosado](https://github.com/aj-rosado) **Base:** `main` ← **Head:** `PM-31835/add-generator-copy-password-field-on-send` --- ### 📝 Commits (10+) - [`b6b7002`](https://github.com/bitwarden/android/commit/b6b70024c3e5a66a56f1f05baf42bb21a0b2e9be) Added new UI for the Email verification on sends - [`5dd79bf`](https://github.com/bitwarden/android/commit/5dd79bf2bc25911cad9a098651da509c055fc006) Merge branch 'main' into PM-31614/update-add-edit-send-ui-email-auth - [`2606d6b`](https://github.com/bitwarden/android/commit/2606d6ba7f1719b018826f0d5795cf0525662bcc) Added copy and generator option to the new AuthTypeChooser password field - [`bc3b881`](https://github.com/bitwarden/android/commit/bc3b881830a97f7ea71232e1cc4692b063a5f27e) Merge branch 'main' into PM-31614/update-add-edit-send-ui-email-auth - [`042a104`](https://github.com/bitwarden/android/commit/042a10486f7890e4e5c91fac63395e51ff4a5f3d) Merge branch 'PM-31614/update-add-edit-send-ui-email-auth' into PM-31835/add-generator-copy-password-field-on-send - [`107ac9f`](https://github.com/bitwarden/android/commit/107ac9f3ca92db15ac91ac3bb67bee0c50dce42d) addressed PR comments - [`9b0b6af`](https://github.com/bitwarden/android/commit/9b0b6afbaff1dba03f3815783587bb8de85a4053) Addressed missing ImmutableList calls and fixed tests - [`c91306b`](https://github.com/bitwarden/android/commit/c91306b0f6502d92d515aad247c78579eec1046c) Merge branch 'main' into PM-31614/update-add-edit-send-ui-email-auth - [`b3053e4`](https://github.com/bitwarden/android/commit/b3053e48d2cedced9f1fa0db861901ee456004f5) fixed SyncServiceTest - [`c813498`](https://github.com/bitwarden/android/commit/c813498484932e2c50c78e5581d23d73aa27fd3f) Revert "fixed SyncServiceTest" ### 📊 Changes **4 files changed** (+236 additions, -11 deletions) <details> <summary>View changed files</summary> 📝 `app/src/main/kotlin/com/x8bit/bitwarden/ui/tools/feature/send/addedit/AddEditSendContent.kt` (+13 -9) 📝 `app/src/main/kotlin/com/x8bit/bitwarden/ui/tools/feature/send/addedit/components/AddEditSendAuthTypeChooser.kt` (+53 -1) 📝 `app/src/main/kotlin/com/x8bit/bitwarden/ui/tools/feature/send/addedit/util/AddEditSendStateExtensions.kt` (+4 -1) 📝 `app/src/test/kotlin/com/x8bit/bitwarden/ui/tools/feature/send/addedit/AddEditSendScreenTest.kt` (+166 -0) </details> ### 📄 Description ## 🎟️ Tracking https://bitwarden.atlassian.net/browse/PM-31835 ## 📔 Objective Add copy and generator button to the password field on the new send's password AuthType ## 📸 Screenshots <img width="360" alt="Screenshot_1770736912" src="https://github.com/user-attachments/assets/a3419f17-f6ba-45a2-9a0f-f4bbb738c58a" /> ## ⏰ Reminders before review - Contributor guidelines followed - All formatters and local linters executed and passed - Written new unit and / or integration tests where applicable - Protected functional changes with optionality (feature flags) - Used internationalization (i18n) for all UI strings - CI builds passed - Communicated to DevOps any deployment requirements - Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team ## 🦮 Reviewer guidelines <!-- Suggested interactions but feel free to use (or not) as you desire! --> - 👍 (`:+1:`) or similar for great changes - 📝 (`:memo:`) or ℹ️ (`:information_source:`) for notes or general info - ❓ (`:question:`) for questions - 🤔 (`:thinking:`) or 💭 (`:thought_balloon:`) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion - 🎨 (`:art:`) for suggestions / improvements - ❌ (`:x:`) or ⚠️ (`:warning:`) for more significant problems or concerns needing attention - 🌱 (`:seedling:`) or ♻️ (`:recycle:`) for future improvements or indications of technical debt - ⛏ (`:pick:`) for minor or nitpick changes --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-15 03:47:33 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#19383
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?