github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-05-07 19:39:41 -05:00
Code Issues 1.1k Packages Projects Releases 122 Wiki Activity

[PR #6275] [MERGED] PM-29843: Record item org migration events #19202

New Issue
Closed
opened 2026-04-15 03:42:02 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-15 03:42:02 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/6275
Author: @SaintPatrck
Created: 12/16/2025
Status: ✅ Merged
Merged: 12/29/2025
Merged by: @SaintPatrck

Base: main ← Head: PM-29843/record-item-org-events

📝 Commits (5)

  • 15ac0cf [PM-28472] Add organization event types for item migration acceptance and rejection
  • feeda3c Add organization event tracking to item migration ViewModels
  • 8c73e2c Merge remote-tracking branch 'origin/main' into PM-29843/record-item-org-events
  • da52b10 Merge remote-tracking branch 'origin/main' into PM-29843/record-item-org-events
  • eb7d7fe Refactor LeaveOrganizationViewModelTest verification logic

📊 Changes

4 files changed (+44 additions, -2 deletions)

View changed files

📝 app/src/main/kotlin/com/x8bit/bitwarden/ui/vault/feature/leaveorganization/LeaveOrganizationViewModel.kt (+6 -0)
📝 app/src/main/kotlin/com/x8bit/bitwarden/ui/vault/feature/migratetomyitems/MigrateToMyItemsViewModel.kt (+6 -0)
📝 app/src/test/kotlin/com/x8bit/bitwarden/ui/vault/feature/leaveorganization/LeaveOrganizationViewModelTest.kt (+13 -1)
📝 app/src/test/kotlin/com/x8bit/bitwarden/ui/vault/feature/migratetomyitems/MigrateToMyItemsViewModelTest.kt (+19 -1)

📄 Description

🎟️ Tracking

PM-29843

📔 Objective

This PR adds organization event tracking to the item migration and leave organization flows. When users accept migrating their personal items to an organization's "My Items" folder, the app now tracks an ItemOrganizationAccepted event. Similarly, when users decline the migration and choose to leave the organization, an ItemOrganizationDeclined event is tracked. These events provide visibility into user decisions regarding personal vault ownership policy enforcement.

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/6275 **Author:** [@SaintPatrck](https://github.com/SaintPatrck) **Created:** 12/16/2025 **Status:** ✅ Merged **Merged:** 12/29/2025 **Merged by:** [@SaintPatrck](https://github.com/SaintPatrck) **Base:** `main` ← **Head:** `PM-29843/record-item-org-events` --- ### 📝 Commits (5) - [`15ac0cf`](https://github.com/bitwarden/android/commit/15ac0cf6ebde84b3359588d429e2a293f984886a) [PM-28472] Add organization event types for item migration acceptance and rejection - [`feeda3c`](https://github.com/bitwarden/android/commit/feeda3c256b1f9f0a05d7d0f28ffd000293f56cb) Add organization event tracking to item migration ViewModels - [`8c73e2c`](https://github.com/bitwarden/android/commit/8c73e2ca011bd76cc22713c03ae9f1c5823bb30f) Merge remote-tracking branch 'origin/main' into PM-29843/record-item-org-events - [`da52b10`](https://github.com/bitwarden/android/commit/da52b10d3f06059f4b18e4ddb56b74abc0195812) Merge remote-tracking branch 'origin/main' into PM-29843/record-item-org-events - [`eb7d7fe`](https://github.com/bitwarden/android/commit/eb7d7fef0016b59e4002a96bacb99308f45ce399) Refactor LeaveOrganizationViewModelTest verification logic ### 📊 Changes **4 files changed** (+44 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `app/src/main/kotlin/com/x8bit/bitwarden/ui/vault/feature/leaveorganization/LeaveOrganizationViewModel.kt` (+6 -0) 📝 `app/src/main/kotlin/com/x8bit/bitwarden/ui/vault/feature/migratetomyitems/MigrateToMyItemsViewModel.kt` (+6 -0) 📝 `app/src/test/kotlin/com/x8bit/bitwarden/ui/vault/feature/leaveorganization/LeaveOrganizationViewModelTest.kt` (+13 -1) 📝 `app/src/test/kotlin/com/x8bit/bitwarden/ui/vault/feature/migratetomyitems/MigrateToMyItemsViewModelTest.kt` (+19 -1) </details> ### 📄 Description ## 🎟️ Tracking PM-29843 ## 📔 Objective This PR adds organization event tracking to the item migration and leave organization flows. When users accept migrating their personal items to an organization's "My Items" folder, the app now tracks an `ItemOrganizationAccepted` event. Similarly, when users decline the migration and choose to leave the organization, an `ItemOrganizationDeclined` event is tracked. These events provide visibility into user decisions regarding personal vault ownership policy enforcement. ## ⏰ Reminders before review - Contributor guidelines followed - All formatters and local linters executed and passed - Written new unit and / or integration tests where applicable - Protected functional changes with optionality (feature flags) - Used internationalization (i18n) for all UI strings - CI builds passed - Communicated to DevOps any deployment requirements - Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team ## 🦮 Reviewer guidelines <!-- Suggested interactions but feel free to use (or not) as you desire! --> - 👍 (`:+1:`) or similar for great changes - 📝 (`:memo:`) or ℹ️ (`:information_source:`) for notes or general info - ❓ (`:question:`) for questions - 🤔 (`:thinking:`) or 💭 (`:thought_balloon:`) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion - 🎨 (`:art:`) for suggestions / improvements - ❌ (`:x:`) or ⚠️ (`:warning:`) for more significant problems or concerns needing attention - 🌱 (`:seedling:`) or ♻️ (`:recycle:`) for future improvements or indications of technical debt - ⛏ (`:pick:`) for minor or nitpick changes --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-15 03:42:03 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#19202
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?