github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-05-06 07:48:22 -05:00
Code Issues 1.1k Packages Projects Releases 122 Wiki Activity

[PR #5817] [MERGED] [PM-23665] Refactor FIDO2 credential discovery #18819

New Issue
Closed
opened 2026-04-15 03:30:51 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-15 03:30:51 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/5817
Author: @SaintPatrck
Created: 9/2/2025
Status: ✅ Merged
Merged: 9/3/2025
Merged by: @SaintPatrck

Base: main ← Head: PM-23665/fido2-allowedCredentials-support

📝 Commits (1)

  • 62032aa [PM-23665] Refactor FIDO2 credential discovery

📊 Changes

2 files changed (+86 additions, -313 deletions)

View changed files

📝 app/src/main/kotlin/com/x8bit/bitwarden/data/credentials/manager/BitwardenCredentialManagerImpl.kt (+55 -50)
📝 app/src/test/kotlin/com/x8bit/bitwarden/data/credentials/manager/BitwardenCredentialManagerTest.kt (+31 -263)

📄 Description

🎟️ Tracking

PM-23665

📔 Objective

Refactor the FIDO2 credential discovery process in BitwardenCredentialManagerImpl. Instead of relying on decrypted CipherListViews, it now uses vaultSdkSource.silentlyDiscoverCredentials to find matching credentials based on the relyingPartyId from the assertion options.

The discovered credentials are then filtered by allowedCredentials if provided in the assertion options.

Additionally, some related test cases in BitwardenCredentialManagerTest were updated to reflect these changes and ensure proper handling of new scenarios, such as when relyingPartyId is null.

📸 Screenshots

image image

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/5817 **Author:** [@SaintPatrck](https://github.com/SaintPatrck) **Created:** 9/2/2025 **Status:** ✅ Merged **Merged:** 9/3/2025 **Merged by:** [@SaintPatrck](https://github.com/SaintPatrck) **Base:** `main` ← **Head:** `PM-23665/fido2-allowedCredentials-support` --- ### 📝 Commits (1) - [`62032aa`](https://github.com/bitwarden/android/commit/62032aaf421d63ab5ebca8c50b7ba981d25fd168) [PM-23665] Refactor FIDO2 credential discovery ### 📊 Changes **2 files changed** (+86 additions, -313 deletions) <details> <summary>View changed files</summary> 📝 `app/src/main/kotlin/com/x8bit/bitwarden/data/credentials/manager/BitwardenCredentialManagerImpl.kt` (+55 -50) 📝 `app/src/test/kotlin/com/x8bit/bitwarden/data/credentials/manager/BitwardenCredentialManagerTest.kt` (+31 -263) </details> ### 📄 Description ## 🎟️ Tracking PM-23665 ## 📔 Objective Refactor the FIDO2 credential discovery process in `BitwardenCredentialManagerImpl`. Instead of relying on decrypted `CipherListViews`, it now uses `vaultSdkSource.silentlyDiscoverCredentials` to find matching credentials based on the `relyingPartyId` from the assertion options. The discovered credentials are then filtered by `allowedCredentials` if provided in the assertion options. Additionally, some related test cases in `BitwardenCredentialManagerTest` were updated to reflect these changes and ensure proper handling of new scenarios, such as when `relyingPartyId` is null. ## 📸 Screenshots <img width="365" alt="image" src="https://github.com/user-attachments/assets/3302c85c-ed0a-43ab-b5bd-877b8c1d7c32" /> <img width="365" alt="image" src="https://github.com/user-attachments/assets/5e3575e8-794c-488c-ac5e-ee9fae426fe6" /> ## ⏰ Reminders before review - Contributor guidelines followed - All formatters and local linters executed and passed - Written new unit and / or integration tests where applicable - Protected functional changes with optionality (feature flags) - Used internationalization (i18n) for all UI strings - CI builds passed - Communicated to DevOps any deployment requirements - Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team ## 🦮 Reviewer guidelines <!-- Suggested interactions but feel free to use (or not) as you desire! --> - 👍 (`:+1:`) or similar for great changes - 📝 (`:memo:`) or ℹ️ (`:information_source:`) for notes or general info - ❓ (`:question:`) for questions - 🤔 (`:thinking:`) or 💭 (`:thought_balloon:`) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion - 🎨 (`:art:`) for suggestions / improvements - ❌ (`:x:`) or ⚠️ (`:warning:`) for more significant problems or concerns needing attention - 🌱 (`:seedling:`) or ♻️ (`:recycle:`) for future improvements or indications of technical debt - ⛏ (`:pick:`) for minor or nitpick changes --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-15 03:30:51 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#18819
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?