github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-05-07 19:39:41 -05:00
Code Issues 1.1k Packages Projects Releases 122 Wiki Activity

[PR #5052] [MERGED] [PM-20192] Migrate CiphersService to network module #18188

New Issue
Closed
opened 2026-04-15 03:12:06 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-15 03:12:06 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/5052
Author: @SaintPatrck
Created: 4/14/2025
Status: ✅ Merged
Merged: 4/16/2025
Merged by: @SaintPatrck

Base: main ← Head: network-module/ciphers-service

📝 Commits (1)

  • 0bec302 [PM-20192] Migrate CiphersService to network module

📊 Changes

14 files changed (+53 additions, -69 deletions)

View changed files

📝 app/src/main/java/com/x8bit/bitwarden/data/vault/datasource/network/di/VaultNetworkModule.kt (+2 -2)
📝 app/src/main/java/com/x8bit/bitwarden/data/vault/manager/CipherManagerImpl.kt (+2 -2)
📝 app/src/main/java/com/x8bit/bitwarden/data/vault/manager/di/VaultManagerModule.kt (+1 -1)
📝 app/src/main/java/com/x8bit/bitwarden/data/vault/repository/VaultRepositoryImpl.kt (+1 -1)
📝 app/src/main/java/com/x8bit/bitwarden/data/vault/repository/di/VaultRepositoryModule.kt (+1 -1)
📝 app/src/test/java/com/x8bit/bitwarden/data/vault/manager/CipherManagerTest.kt (+2 -2)
📝 app/src/test/java/com/x8bit/bitwarden/data/vault/repository/VaultRepositoryTest.kt (+1 -1)
➕ network/src/main/kotlin/com/bitwarden/network/model/AttachmentInfo.kt (+14 -0)
📝 network/src/main/kotlin/com/bitwarden/network/model/ImportCiphersResponseJson.kt (+1 -1)
📝 network/src/main/kotlin/com/bitwarden/network/model/UpdateCipherResponseJson.kt (+1 -2)
📝 network/src/main/kotlin/com/bitwarden/network/service/CiphersService.kt (+5 -5)
📝 network/src/main/kotlin/com/bitwarden/network/service/CiphersServiceImpl.kt (+7 -12)
➕ network/src/test/kotlin/com/bitwarden/network/model/AttachmentInfoUtil.kt (+10 -0)
📝 network/src/test/kotlin/com/bitwarden/network/service/CiphersServiceTest.kt (+5 -39)

📄 Description

🎟️ Tracking

PM-20192

📔 Objective

Move the CiphersService, along with its implementation and related models (ImportCiphersResponseJson, UpdateCipherResponseJson) from the app module to the network module. Also move CiphersServiceTest to the network module.

  • CiphersService and implementation: Moved CiphersService and CiphersServiceImpl from the app module to the network module.
  • Models: Moved ImportCiphersResponseJson and UpdateCipherResponseJson to the network module.
  • CiphersServiceTest: Move this class to the network module.
  • Dependencies: Updated all dependencies on CiphersService, ImportCiphersResponseJson and UpdateCipherResponseJson to point to the new locations in the network module.
  • Add AttachmentInfo: Add this class to describe attachments.

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/5052 **Author:** [@SaintPatrck](https://github.com/SaintPatrck) **Created:** 4/14/2025 **Status:** ✅ Merged **Merged:** 4/16/2025 **Merged by:** [@SaintPatrck](https://github.com/SaintPatrck) **Base:** `main` ← **Head:** `network-module/ciphers-service` --- ### 📝 Commits (1) - [`0bec302`](https://github.com/bitwarden/android/commit/0bec3021da82b1ca1c73a200102394e6baee51ed) [PM-20192] Migrate CiphersService to network module ### 📊 Changes **14 files changed** (+53 additions, -69 deletions) <details> <summary>View changed files</summary> 📝 `app/src/main/java/com/x8bit/bitwarden/data/vault/datasource/network/di/VaultNetworkModule.kt` (+2 -2) 📝 `app/src/main/java/com/x8bit/bitwarden/data/vault/manager/CipherManagerImpl.kt` (+2 -2) 📝 `app/src/main/java/com/x8bit/bitwarden/data/vault/manager/di/VaultManagerModule.kt` (+1 -1) 📝 `app/src/main/java/com/x8bit/bitwarden/data/vault/repository/VaultRepositoryImpl.kt` (+1 -1) 📝 `app/src/main/java/com/x8bit/bitwarden/data/vault/repository/di/VaultRepositoryModule.kt` (+1 -1) 📝 `app/src/test/java/com/x8bit/bitwarden/data/vault/manager/CipherManagerTest.kt` (+2 -2) 📝 `app/src/test/java/com/x8bit/bitwarden/data/vault/repository/VaultRepositoryTest.kt` (+1 -1) ➕ `network/src/main/kotlin/com/bitwarden/network/model/AttachmentInfo.kt` (+14 -0) 📝 `network/src/main/kotlin/com/bitwarden/network/model/ImportCiphersResponseJson.kt` (+1 -1) 📝 `network/src/main/kotlin/com/bitwarden/network/model/UpdateCipherResponseJson.kt` (+1 -2) 📝 `network/src/main/kotlin/com/bitwarden/network/service/CiphersService.kt` (+5 -5) 📝 `network/src/main/kotlin/com/bitwarden/network/service/CiphersServiceImpl.kt` (+7 -12) ➕ `network/src/test/kotlin/com/bitwarden/network/model/AttachmentInfoUtil.kt` (+10 -0) 📝 `network/src/test/kotlin/com/bitwarden/network/service/CiphersServiceTest.kt` (+5 -39) </details> ### 📄 Description ## 🎟️ Tracking PM-20192 ## 📔 Objective Move the `CiphersService`, along with its implementation and related models (`ImportCiphersResponseJson`, `UpdateCipherResponseJson`) from the `app` module to the `network` module. Also move `CiphersServiceTest` to the `network` module. - **CiphersService and implementation**: Moved `CiphersService` and `CiphersServiceImpl` from the `app` module to the `network` module. - **Models**: Moved `ImportCiphersResponseJson` and `UpdateCipherResponseJson` to the `network` module. - **`CiphersServiceTest`:** Move this class to the `network` module. - **Dependencies:** Updated all dependencies on `CiphersService`, `ImportCiphersResponseJson` and `UpdateCipherResponseJson` to point to the new locations in the `network` module. - **Add AttachmentInfo:** Add this class to describe attachments. ## ⏰ Reminders before review - Contributor guidelines followed - All formatters and local linters executed and passed - Written new unit and / or integration tests where applicable - Protected functional changes with optionality (feature flags) - Used internationalization (i18n) for all UI strings - CI builds passed - Communicated to DevOps any deployment requirements - Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team ## 🦮 Reviewer guidelines <!-- Suggested interactions but feel free to use (or not) as you desire! --> - 👍 (`:+1:`) or similar for great changes - 📝 (`:memo:`) or ℹ️ (`:information_source:`) for notes or general info - ❓ (`:question:`) for questions - 🤔 (`:thinking:`) or 💭 (`:thought_balloon:`) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion - 🎨 (`:art:`) for suggestions / improvements - ❌ (`:x:`) or ⚠️ (`:warning:`) for more significant problems or concerns needing attention - 🌱 (`:seedling:`) or ♻️ (`:recycle:`) for future improvements or indications of technical debt - ⛏ (`:pick:`) for minor or nitpick changes --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-15 03:12:06 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#18188
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?