github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-05-07 19:39:41 -05:00
Code Issues 1.1k Packages Projects Releases 122 Wiki Activity

[PR #4772] [CLOSED] [PM-8223] new device verification ux improvements #17952

New Issue
Closed
opened 2026-04-15 03:03:22 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-15 03:03:22 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/4772
Author: @aj-rosado
Created: 2/24/2025
Status: ❌ Closed

Base: main ← Head: PM-8223/new-device-verification-ux-improvements

📝 Commits (5)

  • 0e55eeb Changed error string when invalid code to always use the localized
  • de85e6a fixed tests
  • 5ab5f0e Revert invalid verification code string changes
  • eb267f9 Added test for codeInputChanged on isNewDeviceVerification
  • 46947fd Revert "Revert invalid verification code string changes"

📊 Changes

2 files changed (+34 additions, -7 deletions)

View changed files

📝 app/src/main/java/com/x8bit/bitwarden/ui/auth/feature/twofactorlogin/TwoFactorLoginViewModel.kt (+5 -5)
📝 app/src/test/java/com/x8bit/bitwarden/ui/auth/feature/twofactorlogin/TwoFactorLoginViewModelTest.kt (+29 -2)

📄 Description

🎟️ Tracking

Changing error to always use the localization string and updated "Continue" button to only be enabled when input has eight characters for new device verification

📔 Objective

https://bitwarden.atlassian.net/browse/PM-8223

📸 Screenshots

New device verification error message seven characters long button disabled eight characters long button enabled

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed
    issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/4772 **Author:** [@aj-rosado](https://github.com/aj-rosado) **Created:** 2/24/2025 **Status:** ❌ Closed **Base:** `main` ← **Head:** `PM-8223/new-device-verification-ux-improvements` --- ### 📝 Commits (5) - [`0e55eeb`](https://github.com/bitwarden/android/commit/0e55eeb584ac841b37059d07921f7fd1cc2ae6c8) Changed error string when invalid code to always use the localized - [`de85e6a`](https://github.com/bitwarden/android/commit/de85e6a3d0d4bf46268e3e16e790e48dbf8071f3) fixed tests - [`5ab5f0e`](https://github.com/bitwarden/android/commit/5ab5f0edcc5ff335a02d18874a854fca596b7448) Revert invalid verification code string changes - [`eb267f9`](https://github.com/bitwarden/android/commit/eb267f908915208d35c3aa928e3252e01e845960) Added test for codeInputChanged on isNewDeviceVerification - [`46947fd`](https://github.com/bitwarden/android/commit/46947fdba54a77651131525d23688868872743ff) Revert "Revert invalid verification code string changes" ### 📊 Changes **2 files changed** (+34 additions, -7 deletions) <details> <summary>View changed files</summary> 📝 `app/src/main/java/com/x8bit/bitwarden/ui/auth/feature/twofactorlogin/TwoFactorLoginViewModel.kt` (+5 -5) 📝 `app/src/test/java/com/x8bit/bitwarden/ui/auth/feature/twofactorlogin/TwoFactorLoginViewModelTest.kt` (+29 -2) </details> ### 📄 Description ## 🎟️ Tracking Changing error to always use the localization string and updated "Continue" button to only be enabled when input has eight characters for new device verification ## 📔 Objective https://bitwarden.atlassian.net/browse/PM-8223 ## 📸 Screenshots <img width="314" alt="New device verification error message" src="https://github.com/user-attachments/assets/8f385d2a-1618-43a1-80a3-61e2e1dac992"> <img width="314" alt="seven characters long button disabled" src="https://github.com/user-attachments/assets/8c999089-2630-46d6-bb5b-80b47717ac64"> <img width="314" alt="eight characters long button enabled" src="https://github.com/user-attachments/assets/d9658248-f1d2-403c-a7a7-ce742eae98dc"> ## ⏰ Reminders before review - Contributor guidelines followed - All formatters and local linters executed and passed - Written new unit and / or integration tests where applicable - Used internationalization (i18n) for all UI strings - CI builds passed - Communicated to DevOps any deployment requirements - Updated any necessary documentation or informed the documentation team ## 🦮 Reviewer guidelines <!-- Suggested interactions but feel free to use (or not) as you desire! --> - 👍 (`:+1:`) or similar for great changes - 📝 (`:memo:`) or ℹ️ (`:information_source:`) for notes or general info - ❓ (`:question:`) for questions - 🤔 (`:thinking:`) or 💭 (`:thought_balloon:`) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion - 🎨 (`:art:`) for suggestions / improvements - ❌ (`:x:`) or ⚠️ (`:warning:`) for more significant problems or concerns needing attention - 🌱 (`:seedling:`) or ♻️ (`:recycle:`) for future improvements or indications of technical debt - ⛏ (`:pick:`) for minor or nitpick changes --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-15 03:03:22 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#17952
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?