github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-05-08 04:16:40 -05:00
Code Issues 1.1k Packages Projects Releases 122 Wiki Activity

[PR #4019] [MERGED] BITAU-69 Check for OS version in AuthenticatorBridgeManager #17369

New Issue
Closed
opened 2026-04-15 02:46:12 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-15 02:46:12 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/4019
Author: @ahaisting-livefront
Created: 10/3/2024
Status: ✅ Merged
Merged: 10/3/2024
Merged by: @ahaisting-livefront

Base: main ← Head: check-os-version

📝 Commits (4)

  • 0321f92 BITAU-69 Check for OS version in AuthenticatorBridgeManager
  • b97e8f1 use when instead of chained if
  • 4411c01 change name OSNotSupported -> OsNotSupported
  • 596b616 update test name

📊 Changes

4 files changed (+58 additions, -11 deletions)

View changed files

📝 authenticatorbridge/src/main/java/com/bitwarden/authenticatorbridge/manager/AuthenticatorBridgeManagerImpl.kt (+10 -4)
📝 authenticatorbridge/src/main/java/com/bitwarden/authenticatorbridge/manager/model/AccountSyncState.kt (+5 -0)
➕ authenticatorbridge/src/main/java/com/bitwarden/authenticatorbridge/util/AndroidBuildUtils.kt (+10 -0)
📝 authenticatorbridge/src/test/java/com/bitwarden/authenticatorbridge/manager/AuthenticatorBridgeManagerTest.kt (+33 -7)

📄 Description

🎟️ Tracking

https://livefront.atlassian.net/browse/BITAU-69

📔 Objective

The goal of this PR is to add a check for OS version to the bridge coroutines wrapper.

📸 Screenshots

N/A

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed
    issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/4019 **Author:** [@ahaisting-livefront](https://github.com/ahaisting-livefront) **Created:** 10/3/2024 **Status:** ✅ Merged **Merged:** 10/3/2024 **Merged by:** [@ahaisting-livefront](https://github.com/ahaisting-livefront) **Base:** `main` ← **Head:** `check-os-version` --- ### 📝 Commits (4) - [`0321f92`](https://github.com/bitwarden/android/commit/0321f92d546e1a93a136eeadcd2652dc56d63322) BITAU-69 Check for OS version in AuthenticatorBridgeManager - [`b97e8f1`](https://github.com/bitwarden/android/commit/b97e8f12560f9413f57e2415d53f9301338a2d94) use when instead of chained if - [`4411c01`](https://github.com/bitwarden/android/commit/4411c011b76223c4a8725e53bed6ead87f58c98b) change name OSNotSupported -> OsNotSupported - [`596b616`](https://github.com/bitwarden/android/commit/596b616e4af3a52754358d3262b4544e37fbd023) update test name ### 📊 Changes **4 files changed** (+58 additions, -11 deletions) <details> <summary>View changed files</summary> 📝 `authenticatorbridge/src/main/java/com/bitwarden/authenticatorbridge/manager/AuthenticatorBridgeManagerImpl.kt` (+10 -4) 📝 `authenticatorbridge/src/main/java/com/bitwarden/authenticatorbridge/manager/model/AccountSyncState.kt` (+5 -0) ➕ `authenticatorbridge/src/main/java/com/bitwarden/authenticatorbridge/util/AndroidBuildUtils.kt` (+10 -0) 📝 `authenticatorbridge/src/test/java/com/bitwarden/authenticatorbridge/manager/AuthenticatorBridgeManagerTest.kt` (+33 -7) </details> ### 📄 Description ## 🎟️ Tracking https://livefront.atlassian.net/browse/BITAU-69 ## 📔 Objective The goal of this PR is to add a check for OS version to the bridge coroutines wrapper. ## 📸 Screenshots N/A ## ⏰ Reminders before review - Contributor guidelines followed - All formatters and local linters executed and passed - Written new unit and / or integration tests where applicable - Used internationalization (i18n) for all UI strings - CI builds passed - Communicated to DevOps any deployment requirements - Updated any necessary documentation or informed the documentation team ## 🦮 Reviewer guidelines <!-- Suggested interactions but feel free to use (or not) as you desire! --> - 👍 (`:+1:`) or similar for great changes - 📝 (`:memo:`) or ℹ️ (`:information_source:`) for notes or general info - ❓ (`:question:`) for questions - 🤔 (`:thinking:`) or 💭 (`:thought_balloon:`) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion - 🎨 (`:art:`) for suggestions / improvements - ❌ (`:x:`) or ⚠️ (`:warning:`) for more significant problems or concerns needing attention - 🌱 (`:seedling:`) or ♻️ (`:recycle:`) for future improvements or indications of technical debt - ⛏ (`:pick:`) for minor or nitpick changes --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-15 02:46:12 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#17369
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?