github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-05-07 03:23:29 -05:00
Code Issues 1.1k Packages Projects Releases 122 Wiki Activity

[PR #3941] [CLOSED] [PM-10678] Display all passkeys and accounts in OS prompt #17297

New Issue
Closed
opened 2026-04-15 02:44:13 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-15 02:44:13 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/3941
Author: @SaintPatrck
Created: 9/19/2024
Status: ❌ Closed

Base: main ← Head: PM-10678/passkey-ux-improvements

📝 Commits (10+)

  • b40e591 [PM-11884] Perform origin validation during FIDO 2 auth
  • 2e62f18 Merge branch 'main' into PM-11884/validate-origin-on-auth
  • 11b9259 Merge branch 'main' into PM-11884/validate-origin-on-auth
  • 69270ba [PM-10678] Display all passkeys and accounts in OS prompt
  • 5f7e097 Merge branch 'PM-11884/validate-origin-on-auth' into PM-10678/passkey-ux-improvements
  • 2d3f98c Terminate FIDO 2 operation when error dialog is dismissed
  • 3cd9fcb Add tests for Fido2ViewModel
  • b472795 Merge remote-tracking branch 'origin/main' into PM-10678/passkey-ux-improvements
  • e9d979f Update tests after merge
  • b9e1507 Merge remote-tracking branch 'origin/main' into PM-10678/passkey-ux-improvements

📊 Changes

33 files changed (+3565 additions, -1277 deletions)

View changed files

📝 app/src/main/java/com/x8bit/bitwarden/data/autofill/fido2/di/Fido2ProviderModule.kt (+0 -2)
📝 app/src/main/java/com/x8bit/bitwarden/data/autofill/fido2/model/Fido2CredentialAssertionRequest.kt (+1 -0)
📝 app/src/main/java/com/x8bit/bitwarden/data/autofill/fido2/model/Fido2GetCredentialsRequest.kt (+1 -8)
📝 app/src/main/java/com/x8bit/bitwarden/data/autofill/fido2/model/Fido2GetCredentialsResult.kt (+9 -3)
📝 app/src/main/java/com/x8bit/bitwarden/data/autofill/fido2/processor/Fido2ProviderProcessorImpl.kt (+91 -53)
📝 app/src/main/java/com/x8bit/bitwarden/data/autofill/fido2/util/Fido2IntentUtils.kt (+6 -5)
📝 app/src/main/java/com/x8bit/bitwarden/data/vault/datasource/sdk/model/Fido2CredentialStoreImpl.kt (+0 -4)
📝 app/src/main/java/com/x8bit/bitwarden/ui/auth/feature/vaultunlock/VaultUnlockScreen.kt (+41 -7)
📝 app/src/main/java/com/x8bit/bitwarden/ui/auth/feature/vaultunlock/VaultUnlockViewModel.kt (+95 -7)
➕ app/src/main/java/com/x8bit/bitwarden/ui/autofill/fido2/Fido2Navigation.kt (+42 -0)
➕ app/src/main/java/com/x8bit/bitwarden/ui/autofill/fido2/Fido2Screen.kt (+206 -0)
➕ app/src/main/java/com/x8bit/bitwarden/ui/autofill/fido2/Fido2ViewModel.kt (+947 -0)
➕ app/src/main/java/com/x8bit/bitwarden/ui/autofill/fido2/handlers/Fido2DialogHandlers.kt (+78 -0)
➕ app/src/main/java/com/x8bit/bitwarden/ui/autofill/fido2/handlers/Fido2UserVerificationHandlers.kt (+53 -0)
📝 app/src/main/java/com/x8bit/bitwarden/ui/autofill/fido2/manager/Fido2CompletionManagerImpl.kt (+36 -13)
📝 app/src/main/java/com/x8bit/bitwarden/ui/platform/feature/rootnav/RootNavScreen.kt (+12 -5)
📝 app/src/main/java/com/x8bit/bitwarden/ui/platform/manager/intent/IntentManager.kt (+2 -0)
📝 app/src/main/java/com/x8bit/bitwarden/ui/platform/manager/intent/IntentManagerImpl.kt (+9 -5)
📝 app/src/main/java/com/x8bit/bitwarden/ui/vault/feature/itemlisting/VaultItemListingScreen.kt (+0 -8)
📝 app/src/main/java/com/x8bit/bitwarden/ui/vault/feature/itemlisting/VaultItemListingViewModel.kt (+17 -276)

...and 13 more files

📄 Description

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-10678

📔 Objective

Extract credential selection and authentication to a dedicated View.

📸 Screenshots

Scenario Before After
All accounts locked Cell image
All accounts locked (Sign-in options) Cell image
All accounts unlocked Cell image
All accounts unlocked (Sign-in options) Cell image
Checked all accounts Cell image
Checked all accounts (Sign-in options) Cell image
User verification Cell image

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed
    issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/3941 **Author:** [@SaintPatrck](https://github.com/SaintPatrck) **Created:** 9/19/2024 **Status:** ❌ Closed **Base:** `main` ← **Head:** `PM-10678/passkey-ux-improvements` --- ### 📝 Commits (10+) - [`b40e591`](https://github.com/bitwarden/android/commit/b40e5911b9495fea95eb8b49ea693fb5c5dbb9f9) [PM-11884] Perform origin validation during FIDO 2 auth - [`2e62f18`](https://github.com/bitwarden/android/commit/2e62f1876e93005db743bfa19399199acd0cd305) Merge branch 'main' into PM-11884/validate-origin-on-auth - [`11b9259`](https://github.com/bitwarden/android/commit/11b9259273db72c207ed43f3c024d569a608b5d6) Merge branch 'main' into PM-11884/validate-origin-on-auth - [`69270ba`](https://github.com/bitwarden/android/commit/69270baa235ccf25190b6dfd3532f5bea160a7df) [PM-10678] Display all passkeys and accounts in OS prompt - [`5f7e097`](https://github.com/bitwarden/android/commit/5f7e0972bcb45fdb1c0e1051113b0cf51f334cfa) Merge branch 'PM-11884/validate-origin-on-auth' into PM-10678/passkey-ux-improvements - [`2d3f98c`](https://github.com/bitwarden/android/commit/2d3f98cab6492bf46bf5197e79bbe9bf52a74d95) Terminate FIDO 2 operation when error dialog is dismissed - [`3cd9fcb`](https://github.com/bitwarden/android/commit/3cd9fcb5644f1ffde1e2fb8a3acba9abc5689828) Add tests for Fido2ViewModel - [`b472795`](https://github.com/bitwarden/android/commit/b472795614e283c7038d868d3360e922b52eba4d) Merge remote-tracking branch 'origin/main' into PM-10678/passkey-ux-improvements - [`e9d979f`](https://github.com/bitwarden/android/commit/e9d979fa7960a62604f398e94276f522329334ac) Update tests after merge - [`b9e1507`](https://github.com/bitwarden/android/commit/b9e15077a1767181981f984ec0d22140b5b241fc) Merge remote-tracking branch 'origin/main' into PM-10678/passkey-ux-improvements ### 📊 Changes **33 files changed** (+3565 additions, -1277 deletions) <details> <summary>View changed files</summary> 📝 `app/src/main/java/com/x8bit/bitwarden/data/autofill/fido2/di/Fido2ProviderModule.kt` (+0 -2) 📝 `app/src/main/java/com/x8bit/bitwarden/data/autofill/fido2/model/Fido2CredentialAssertionRequest.kt` (+1 -0) 📝 `app/src/main/java/com/x8bit/bitwarden/data/autofill/fido2/model/Fido2GetCredentialsRequest.kt` (+1 -8) 📝 `app/src/main/java/com/x8bit/bitwarden/data/autofill/fido2/model/Fido2GetCredentialsResult.kt` (+9 -3) 📝 `app/src/main/java/com/x8bit/bitwarden/data/autofill/fido2/processor/Fido2ProviderProcessorImpl.kt` (+91 -53) 📝 `app/src/main/java/com/x8bit/bitwarden/data/autofill/fido2/util/Fido2IntentUtils.kt` (+6 -5) 📝 `app/src/main/java/com/x8bit/bitwarden/data/vault/datasource/sdk/model/Fido2CredentialStoreImpl.kt` (+0 -4) 📝 `app/src/main/java/com/x8bit/bitwarden/ui/auth/feature/vaultunlock/VaultUnlockScreen.kt` (+41 -7) 📝 `app/src/main/java/com/x8bit/bitwarden/ui/auth/feature/vaultunlock/VaultUnlockViewModel.kt` (+95 -7) ➕ `app/src/main/java/com/x8bit/bitwarden/ui/autofill/fido2/Fido2Navigation.kt` (+42 -0) ➕ `app/src/main/java/com/x8bit/bitwarden/ui/autofill/fido2/Fido2Screen.kt` (+206 -0) ➕ `app/src/main/java/com/x8bit/bitwarden/ui/autofill/fido2/Fido2ViewModel.kt` (+947 -0) ➕ `app/src/main/java/com/x8bit/bitwarden/ui/autofill/fido2/handlers/Fido2DialogHandlers.kt` (+78 -0) ➕ `app/src/main/java/com/x8bit/bitwarden/ui/autofill/fido2/handlers/Fido2UserVerificationHandlers.kt` (+53 -0) 📝 `app/src/main/java/com/x8bit/bitwarden/ui/autofill/fido2/manager/Fido2CompletionManagerImpl.kt` (+36 -13) 📝 `app/src/main/java/com/x8bit/bitwarden/ui/platform/feature/rootnav/RootNavScreen.kt` (+12 -5) 📝 `app/src/main/java/com/x8bit/bitwarden/ui/platform/manager/intent/IntentManager.kt` (+2 -0) 📝 `app/src/main/java/com/x8bit/bitwarden/ui/platform/manager/intent/IntentManagerImpl.kt` (+9 -5) 📝 `app/src/main/java/com/x8bit/bitwarden/ui/vault/feature/itemlisting/VaultItemListingScreen.kt` (+0 -8) 📝 `app/src/main/java/com/x8bit/bitwarden/ui/vault/feature/itemlisting/VaultItemListingViewModel.kt` (+17 -276) _...and 13 more files_ </details> ### 📄 Description ## 🎟️ Tracking https://bitwarden.atlassian.net/browse/PM-10678 ## 📔 Objective Extract credential selection and authentication to a dedicated View. ## 📸 Screenshots |Scenario | Before | After | |--------|--------|--------| | All accounts locked | Cell | <img width="381" alt="image" src="https://github.com/user-attachments/assets/ade9c4b5-bee7-473e-ad0d-6f2d2ac0ae41"> | | All accounts locked (Sign-in options) | Cell | <img width="365" alt="image" src="https://github.com/user-attachments/assets/1efea3e2-e6be-48ed-a8b1-2d68f97de9ef"> | | All accounts unlocked | Cell | <img width="365" alt="image" src="https://github.com/user-attachments/assets/156b6b7c-a2f6-43ce-818e-80a64b7be247"> | | All accounts unlocked (Sign-in options) | Cell | <img width="376" alt="image" src="https://github.com/user-attachments/assets/94a725bc-e962-43ff-9404-51c0200842b5"> | | Checked all accounts | Cell | <img width="378" alt="image" src="https://github.com/user-attachments/assets/6064fd95-af5f-421e-9b60-70161d89ff4a"> | | Checked all accounts (Sign-in options) | Cell | <img width="376" alt="image" src="https://github.com/user-attachments/assets/2aa5f9b6-48d9-4e1b-b4a2-22d51c5a8fe3"> | | User verification | Cell | <img width="378" alt="image" src="https://github.com/user-attachments/assets/f25041ce-0e8d-48d1-aef4-4473a859c9ac"> | ## ⏰ Reminders before review - Contributor guidelines followed - All formatters and local linters executed and passed - Written new unit and / or integration tests where applicable - Used internationalization (i18n) for all UI strings - CI builds passed - Communicated to DevOps any deployment requirements - Updated any necessary documentation or informed the documentation team ## 🦮 Reviewer guidelines <!-- Suggested interactions but feel free to use (or not) as you desire! --> - 👍 (`:+1:`) or similar for great changes - 📝 (`:memo:`) or ℹ️ (`:information_source:`) for notes or general info - ❓ (`:question:`) for questions - 🤔 (`:thinking:`) or 💭 (`:thought_balloon:`) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion - 🎨 (`:art:`) for suggestions / improvements - ❌ (`:x:`) or ⚠️ (`:warning:`) for more significant problems or concerns needing attention - 🌱 (`:seedling:`) or ♻️ (`:recycle:`) for future improvements or indications of technical debt - ⛏ (`:pick:`) for minor or nitpick changes --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-15 02:44:13 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#17297
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?