github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-05-07 19:39:41 -05:00
Code Issues 1.1k Packages Projects Releases 122 Wiki Activity

[PR #3599] [MERGED] PM-9532 pt. 1 small refactor of login success steps #17028

New Issue
Closed
opened 2026-04-15 02:36:01 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-15 02:36:01 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/3599
Author: @dseverns-livefront
Created: 7/22/2024
Status: ✅ Merged
Merged: 7/23/2024
Merged by: @dseverns-livefront

Base: main ← Head: PM-9532/vault-error-not-propagated-on-login

📝 Commits (1)

  • 619afab PM-9532 reorder vault unlock operations to the top of the login success

📊 Changes

1 file changed (+45 additions, -44 deletions)

View changed files

📝 app/src/main/java/com/x8bit/bitwarden/data/auth/repository/AuthRepositoryImpl.kt (+45 -44)

📄 Description

This is a small refactor of some of the Login common code, the end goal of PM-9532 will be to propagate any non API (read SDK) errors that can occur in the login flow (such as unlocking the vault). The change here moves all the unlock vault code to the top of the call stack in the handleLoginCommonSuccess function.

The goal of this PR is to isolate this logic reordering to allow for regression testing without any other changes related to propagating the error message.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/3599 **Author:** [@dseverns-livefront](https://github.com/dseverns-livefront) **Created:** 7/22/2024 **Status:** ✅ Merged **Merged:** 7/23/2024 **Merged by:** [@dseverns-livefront](https://github.com/dseverns-livefront) **Base:** `main` ← **Head:** `PM-9532/vault-error-not-propagated-on-login` --- ### 📝 Commits (1) - [`619afab`](https://github.com/bitwarden/android/commit/619afab951de26ae6a1f981c40f0e0f931c7bccb) PM-9532 reorder vault unlock operations to the top of the login success ### 📊 Changes **1 file changed** (+45 additions, -44 deletions) <details> <summary>View changed files</summary> 📝 `app/src/main/java/com/x8bit/bitwarden/data/auth/repository/AuthRepositoryImpl.kt` (+45 -44) </details> ### 📄 Description This is a small refactor of some of the Login common code, the end goal of [PM-9532](https://bitwarden.atlassian.net/browse/PM-9532) will be to propagate any non API (read SDK) errors that can occur in the login flow (such as unlocking the vault). The change here moves all the unlock vault code to the top of the call stack in the `handleLoginCommonSuccess` function. The goal of this PR is to isolate this logic reordering to allow for regression testing without any other changes related to propagating the error message. [PM-9532]: https://bitwarden.atlassian.net/browse/PM-9532?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-15 02:36:01 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#17028
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?