github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-05-17 12:36:15 -05:00
Code Issues 1.3k Packages Projects Releases 125 Wiki Activity

[PR #3175] [MERGED] [PM-7585] Show error message when Origin is null on Fido2 Android #16826

New Issue
Closed
opened 2026-04-15 02:30:05 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-15 02:30:05 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/3175
Author: @fedemkr
Created: 4/19/2024
Status: ✅ Merged
Merged: 4/19/2024
Merged by: @fedemkr

Base: feature/maui-migration-passkeys ← Head: mobiletf/pm-7585/error-message-on-app

📝 Commits (1)

  • f68f181 PM-7585 Show error message when Origin is null, given no support for passkeys from native apps yet

📊 Changes

4 files changed (+28 additions, -0 deletions)

View changed files

📝 src/App/Platforms/Android/Autofill/CredentialHelpers.cs (+9 -0)
📝 src/App/Platforms/Android/Autofill/CredentialProviderSelectionActivity.cs (+7 -0)
📝 src/Core/Resources/Localization/AppResources.Designer.cs (+9 -0)
📝 src/Core/Resources/Localization/AppResources.resx (+3 -0)

📄 Description

Type of change

  • Bug fix
  • New feature development
  • Tech debt (refactoring, code cleanup, dependency upgrades, etc)
  • Build/deploy pipeline (DevOps)
  • Other

Objective

Show error message when trying to use/create a fido2 credential on Android from a native app, i.e. origin is null

Before you submit

  • Please check for formatting errors (dotnet format --verify-no-changes) (required)
  • Please add unit tests where it makes sense to do so (encouraged but not required)
  • If this change requires a documentation update - notify the documentation team
  • If this change has particular deployment requirements - notify the DevOps team

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/3175 **Author:** [@fedemkr](https://github.com/fedemkr) **Created:** 4/19/2024 **Status:** ✅ Merged **Merged:** 4/19/2024 **Merged by:** [@fedemkr](https://github.com/fedemkr) **Base:** `feature/maui-migration-passkeys` ← **Head:** `mobiletf/pm-7585/error-message-on-app` --- ### 📝 Commits (1) - [`f68f181`](https://github.com/bitwarden/android/commit/f68f181b20100bebe1ad89443f01967b8e984871) PM-7585 Show error message when Origin is null, given no support for passkeys from native apps yet ### 📊 Changes **4 files changed** (+28 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `src/App/Platforms/Android/Autofill/CredentialHelpers.cs` (+9 -0) 📝 `src/App/Platforms/Android/Autofill/CredentialProviderSelectionActivity.cs` (+7 -0) 📝 `src/Core/Resources/Localization/AppResources.Designer.cs` (+9 -0) 📝 `src/Core/Resources/Localization/AppResources.resx` (+3 -0) </details> ### 📄 Description ## Type of change - [ ] Bug fix - [ ] New feature development - [X] Tech debt (refactoring, code cleanup, dependency upgrades, etc) - [ ] Build/deploy pipeline (DevOps) - [ ] Other ## Objective <!--Describe what the purpose of this PR is. For example: what bug you're fixing or what new feature you're adding--> Show error message when trying to use/create a fido2 credential on Android from a native app, i.e. origin is `null` ## Before you submit - Please check for formatting errors (`dotnet format --verify-no-changes`) (required) - Please add **unit tests** where it makes sense to do so (encouraged but not required) - If this change requires a **documentation update** - notify the documentation team - If this change has particular **deployment requirements** - notify the DevOps team --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-15 02:30:05 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#16826
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?