github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-05-16 19:20:45 -05:00
Code Issues 1.3k Packages Projects Releases 115 Wiki Activity

[PR #3171] [MERGED] [PM-7365] Fix UV not being performed on Fido2 credential creation Android #16822

New Issue
Closed
opened 2026-04-15 02:29:52 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-15 02:29:52 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/3171
Author: @fedemkr
Created: 4/18/2024
Status: ✅ Merged
Merged: 4/19/2024
Merged by: @fedemkr

Base: feature/maui-migration-passkeys ← Head: mobiletf/pm-7365/fix-uv-fido2-android-creation

📝 Commits (3)

  • 25deaaa PM-7365 Fix UV not being performed on Fido2 credential creation on Android
  • 31ce014 Merge branch 'feature/maui-migration-passkeys' into mobiletf/pm-7365/fix-uv-fido2-android-creation
  • 00532d8 PM-7365 Fix PublicKeyCredentialCreationOptions mapping from json on AuthenticatorSelection so mainly userVerification has correct value

📊 Changes

2 files changed (+18 additions, -2 deletions)

View changed files

📝 src/App/Platforms/Android/Autofill/CredentialHelpers.cs (+17 -2)
📝 src/Core/App.xaml.cs (+1 -0)

📄 Description

Type of change

  • Bug fix
  • New feature development
  • Tech debt (refactoring, code cleanup, dependency upgrades, etc)
  • Build/deploy pipeline (DevOps)
  • Other

Objective

Fix UV not being performed on Fido2 credential creation Android

Code changes

  • App.xaml.cs: Update the flag on Options for successive OnCreate calls of MainActivity

Before you submit

  • Please check for formatting errors (dotnet format --verify-no-changes) (required)
  • Please add unit tests where it makes sense to do so (encouraged but not required)
  • If this change requires a documentation update - notify the documentation team
  • If this change has particular deployment requirements - notify the DevOps team

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/3171 **Author:** [@fedemkr](https://github.com/fedemkr) **Created:** 4/18/2024 **Status:** ✅ Merged **Merged:** 4/19/2024 **Merged by:** [@fedemkr](https://github.com/fedemkr) **Base:** `feature/maui-migration-passkeys` ← **Head:** `mobiletf/pm-7365/fix-uv-fido2-android-creation` --- ### 📝 Commits (3) - [`25deaaa`](https://github.com/bitwarden/android/commit/25deaaa54e4ec7b1bc24ac7f5a512c140f7603c3) PM-7365 Fix UV not being performed on Fido2 credential creation on Android - [`31ce014`](https://github.com/bitwarden/android/commit/31ce01476026029c9a48350044d108d4a67b0b06) Merge branch 'feature/maui-migration-passkeys' into mobiletf/pm-7365/fix-uv-fido2-android-creation - [`00532d8`](https://github.com/bitwarden/android/commit/00532d857cbaaaf536d64375be999f5783446dc9) PM-7365 Fix PublicKeyCredentialCreationOptions mapping from json on AuthenticatorSelection so mainly userVerification has correct value ### 📊 Changes **2 files changed** (+18 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `src/App/Platforms/Android/Autofill/CredentialHelpers.cs` (+17 -2) 📝 `src/Core/App.xaml.cs` (+1 -0) </details> ### 📄 Description ## Type of change - [X] Bug fix - [ ] New feature development - [ ] Tech debt (refactoring, code cleanup, dependency upgrades, etc) - [ ] Build/deploy pipeline (DevOps) - [ ] Other ## Objective <!--Describe what the purpose of this PR is. For example: what bug you're fixing or what new feature you're adding--> Fix UV not being performed on Fido2 credential creation Android ## Code changes <!--Explain the changes you've made to each file or major component. This should help the reviewer understand your changes--> <!--Also refer to any related changes or PRs in other repositories--> * **App.xaml.cs:** Update the flag on `Options` for successive `OnCreate` calls of `MainActivity` ## Before you submit - Please check for formatting errors (`dotnet format --verify-no-changes`) (required) - Please add **unit tests** where it makes sense to do so (encouraged but not required) - If this change requires a **documentation update** - notify the documentation team - If this change has particular **deployment requirements** - notify the DevOps team --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-15 02:29:52 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#16822
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?