github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-05-08 21:10:40 -05:00
Code Issues 1.1k Packages Projects Releases 122 Wiki Activity

[PR #3077] [MERGED] Feature/maui migraton passkeys android unlock fix andreas #16761

New Issue
Closed
opened 2026-04-15 02:27:00 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-15 02:27:00 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/3077
Author: @coroiu
Created: 3/13/2024
Status: ✅ Merged
Merged: 3/13/2024
Merged by: @dinisvieira

Base: feature/maui-migraton-passkeys-android-unlock ← Head: feature/maui-migraton-passkeys-android-unlock-fix-andreas

📝 Commits (3)

  • e037e0a fix: bitwarden providing too many/wrong credentials
  • 57bcd35 feat: use authenticator instead of client
  • 9aeb006 Merge branch 'feature/maui-migraton-passkeys-android-unlock' into feature/maui-migraton-passkeys-android-unlock-fix-andreas

📊 Changes

5 files changed (+55 additions, -133 deletions)

View changed files

📝 src/App/Platforms/Android/Autofill/CredentialHelpers.cs (+16 -28)
📝 src/App/Platforms/Android/Autofill/CredentialProviderSelectionActivity.cs (+32 -102)
📝 src/Core/Services/Fido2AuthenticatorService.cs (+3 -2)
📝 src/Core/Utilities/Fido2/Fido2AuthenticatorDiscoverableCredentialMetadata.cs (+2 -0)
📝 test/Core.Test/Services/Fido2AuthenticatorSilentCredentialDiscoveryTests.cs (+2 -1)

📄 Description

Type of change

  • Bug fix
  • New feature development
  • Tech debt (refactoring, code cleanup, dependency upgrades, etc)
  • Build/deploy pipeline (DevOps)
  • Other

Objective

Code changes

  • file.ext: Description of what was changed and why

Screenshots

Before you submit

  • Please check for formatting errors (dotnet format --verify-no-changes) (required)
  • Please add unit tests where it makes sense to do so (encouraged but not required)
  • If this change requires a documentation update - notify the documentation team
  • If this change has particular deployment requirements - notify the DevOps team

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/3077 **Author:** [@coroiu](https://github.com/coroiu) **Created:** 3/13/2024 **Status:** ✅ Merged **Merged:** 3/13/2024 **Merged by:** [@dinisvieira](https://github.com/dinisvieira) **Base:** `feature/maui-migraton-passkeys-android-unlock` ← **Head:** `feature/maui-migraton-passkeys-android-unlock-fix-andreas` --- ### 📝 Commits (3) - [`e037e0a`](https://github.com/bitwarden/android/commit/e037e0ab4838521ae2bc89aef785afde81d79d7c) fix: bitwarden providing too many/wrong credentials - [`57bcd35`](https://github.com/bitwarden/android/commit/57bcd35230163216a45acc6074dd9b85fa541397) feat: use authenticator instead of client - [`9aeb006`](https://github.com/bitwarden/android/commit/9aeb006c0584af1bf58727b795492648cbf0586d) Merge branch 'feature/maui-migraton-passkeys-android-unlock' into feature/maui-migraton-passkeys-android-unlock-fix-andreas ### 📊 Changes **5 files changed** (+55 additions, -133 deletions) <details> <summary>View changed files</summary> 📝 `src/App/Platforms/Android/Autofill/CredentialHelpers.cs` (+16 -28) 📝 `src/App/Platforms/Android/Autofill/CredentialProviderSelectionActivity.cs` (+32 -102) 📝 `src/Core/Services/Fido2AuthenticatorService.cs` (+3 -2) 📝 `src/Core/Utilities/Fido2/Fido2AuthenticatorDiscoverableCredentialMetadata.cs` (+2 -0) 📝 `test/Core.Test/Services/Fido2AuthenticatorSilentCredentialDiscoveryTests.cs` (+2 -1) </details> ### 📄 Description ## Type of change - [ ] Bug fix - [ ] New feature development - [ ] Tech debt (refactoring, code cleanup, dependency upgrades, etc) - [ ] Build/deploy pipeline (DevOps) - [ ] Other ## Objective <!--Describe what the purpose of this PR is. For example: what bug you're fixing or what new feature you're adding--> ## Code changes <!--Explain the changes you've made to each file or major component. This should help the reviewer understand your changes--> <!--Also refer to any related changes or PRs in other repositories--> * **file.ext:** Description of what was changed and why ## Screenshots <!--Required for any UI changes. Delete if not applicable--> ## Before you submit - Please check for formatting errors (`dotnet format --verify-no-changes`) (required) - Please add **unit tests** where it makes sense to do so (encouraged but not required) - If this change requires a **documentation update** - notify the documentation team - If this change has particular **deployment requirements** - notify the DevOps team --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-15 02:27:00 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#16761
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?