github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-05-08 04:16:40 -05:00
Code Issues 1.1k Packages Projects Releases 122 Wiki Activity

[PR #3014] [MERGED] [PM-5909] Fix Font MAUI Sizes #16712

New Issue
Closed
opened 2026-04-15 02:25:00 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-15 02:25:00 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/3014
Author: @dinisvieira
Created: 2/19/2024
Status: ✅ Merged
Merged: 2/20/2024
Merged by: @dinisvieira

Base: main ← Head: feature/PM-5909-fix-maui-font-sizes

📝 Commits (3)

  • 5c16448 PM-5909 Set the default FontSize for Entry, Editor, SearchBar and Picker on Android so that the fonts have a similar size to the one in the Xamarin Forms app.
  • 4908057 PM-5909 Set the default FontSize for Entry, Editor, SearchBar and Picker on iOS so that the fonts have a similar size to the one in the Xamarin Forms app.
  • 13dd8f1 PM-5909 Added spacing in specific scenario for Send Groups (between icon and text)

📊 Changes

3 files changed (+17 additions, -0 deletions)

View changed files

📝 src/Core/Pages/Send/SendGroupingsPage/SendGroupingsPage.xaml (+1 -0)
📝 src/Core/Resources/Styles/Android.xaml (+8 -0)
📝 src/Core/Resources/Styles/iOS.xaml (+8 -0)

📄 Description

Type of change

  • Bug fix
  • New feature development
  • Tech debt (refactoring, code cleanup, dependency upgrades, etc)
  • Build/deploy pipeline (DevOps)
  • Other

Objective

Font Size on some controls in the MAUI app is different from Xamarin Forms. Ideally it should be the same.

Code changes

As far as I could tell MAUI no longer uses the same Font Size default that we had in Xamarin Forms.
The most obvious issues seemed to be on Entry, Editor, Picker and SearchBar.
In code I set these base controls to always have a default of FontSize="18" which seems to be the same as the Xamarin Forms app.

Also added a spacing on SendGroupingsPage.xaml between icon and text. (this wasn't an issue in Xamarin Forms because XF has a default Spacing of 6)

  • Android.xaml: Set the default FontSize to 18 on Entry, Editor, Picker and SearchBar. (for Android)
  • iOS.xaml: Set the default FontSize to 18 on Entry, Editor, Picker and SearchBar. (for iOS)
  • SendGroupingsPage.xaml: Added a spacing on SendGroupingsPage.xaml between icon and text.

Before you submit

  • Please check for formatting errors (dotnet format --verify-no-changes) (required)
  • Please add unit tests where it makes sense to do so (encouraged but not required)
  • If this change requires a documentation update - notify the documentation team
  • If this change has particular deployment requirements - notify the DevOps team

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/3014 **Author:** [@dinisvieira](https://github.com/dinisvieira) **Created:** 2/19/2024 **Status:** ✅ Merged **Merged:** 2/20/2024 **Merged by:** [@dinisvieira](https://github.com/dinisvieira) **Base:** `main` ← **Head:** `feature/PM-5909-fix-maui-font-sizes` --- ### 📝 Commits (3) - [`5c16448`](https://github.com/bitwarden/android/commit/5c1644870ebef581850614e0229db6da275a946a) PM-5909 Set the default FontSize for Entry, Editor, SearchBar and Picker on Android so that the fonts have a similar size to the one in the Xamarin Forms app. - [`4908057`](https://github.com/bitwarden/android/commit/4908057ba7fa6294002f3b9b8e4bcc2b2bf4ac2d) PM-5909 Set the default FontSize for Entry, Editor, SearchBar and Picker on iOS so that the fonts have a similar size to the one in the Xamarin Forms app. - [`13dd8f1`](https://github.com/bitwarden/android/commit/13dd8f144b83051a9923ab0bafb7fd4c31e37ad6) PM-5909 Added spacing in specific scenario for Send Groups (between icon and text) ### 📊 Changes **3 files changed** (+17 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `src/Core/Pages/Send/SendGroupingsPage/SendGroupingsPage.xaml` (+1 -0) 📝 `src/Core/Resources/Styles/Android.xaml` (+8 -0) 📝 `src/Core/Resources/Styles/iOS.xaml` (+8 -0) </details> ### 📄 Description ## Type of change - [x] Bug fix - [ ] New feature development - [ ] Tech debt (refactoring, code cleanup, dependency upgrades, etc) - [ ] Build/deploy pipeline (DevOps) - [ ] Other ## Objective Font Size on some controls in the MAUI app is different from Xamarin Forms. Ideally it should be the same. ## Code changes As far as I could tell MAUI no longer uses the same Font Size default that we had in Xamarin Forms. The most obvious issues seemed to be on `Entry`, `Editor`, `Picker` and `SearchBar`. In code I set these base controls to always have a default of `FontSize="18"` which seems to be the same as the Xamarin Forms app. Also added a spacing on `SendGroupingsPage.xaml` between icon and text. (this wasn't an issue in Xamarin Forms because XF has a default Spacing of 6) * **Android.xaml:** Set the default FontSize to 18 on `Entry`, `Editor`, `Picker` and `SearchBar`. (for Android) * **iOS.xaml:** Set the default FontSize to 18 on `Entry`, `Editor`, `Picker` and `SearchBar`. (for iOS) * **SendGroupingsPage.xaml:** Added a spacing on `SendGroupingsPage.xaml` between icon and text. ## Before you submit - Please check for formatting errors (`dotnet format --verify-no-changes`) (required) - Please add **unit tests** where it makes sense to do so (encouraged but not required) - If this change requires a **documentation update** - notify the documentation team - If this change has particular **deployment requirements** - notify the DevOps team --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-15 02:25:00 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#16712
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?