github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-05-08 04:16:40 -05:00
Code Issues 1.1k Packages Projects Releases 122 Wiki Activity

[PR #2828] [MERGED] [PM-4314] Removed move passkey to organization duplicate check #16585

New Issue
Closed
opened 2026-04-15 02:20:58 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-15 02:20:58 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/2828
Author: @fedemkr
Created: 10/17/2023
Status: ✅ Merged
Merged: 10/17/2023
Merged by: @fedemkr

Base: master ← Head: vault/pm-4314/remove-duplicate-check-moving-passkey-item-to-org

📝 Commits (1)

  • 256e9c7 PM-4314 Removed move passkey to organization duplicate check

📊 Changes

5 files changed (+3 additions, -48 deletions)

View changed files

📝 src/App/Pages/Vault/SharePageViewModel.cs (+1 -7)
📝 src/App/Resources/AppResources.Designer.cs (+0 -10)
📝 src/App/Resources/AppResources.resx (+0 -3)
📝 src/Core/Abstractions/ICipherService.cs (+1 -7)
📝 src/Core/Services/CipherService.cs (+1 -21)

📄 Description

Type of change

  • Bug fix
  • New feature development
  • Tech debt (refactoring, code cleanup, dependency upgrades, etc)
  • Build/deploy pipeline (DevOps)
  • Other

Objective

Removed duplicate check when moving a passkey to an organization.

Code changes

  • Removed logic that was checking passkey duplication when moving a personal vault passkey to an organization.

Before you submit

  • Please check for formatting errors (dotnet format --verify-no-changes) (required)
  • Please add unit tests where it makes sense to do so (encouraged but not required)
  • If this change requires a documentation update - notify the documentation team
  • If this change has particular deployment requirements - notify the DevOps team

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/2828 **Author:** [@fedemkr](https://github.com/fedemkr) **Created:** 10/17/2023 **Status:** ✅ Merged **Merged:** 10/17/2023 **Merged by:** [@fedemkr](https://github.com/fedemkr) **Base:** `master` ← **Head:** `vault/pm-4314/remove-duplicate-check-moving-passkey-item-to-org` --- ### 📝 Commits (1) - [`256e9c7`](https://github.com/bitwarden/android/commit/256e9c7422cf35cea7e750e16c234aad3cfdbd2b) PM-4314 Removed move passkey to organization duplicate check ### 📊 Changes **5 files changed** (+3 additions, -48 deletions) <details> <summary>View changed files</summary> 📝 `src/App/Pages/Vault/SharePageViewModel.cs` (+1 -7) 📝 `src/App/Resources/AppResources.Designer.cs` (+0 -10) 📝 `src/App/Resources/AppResources.resx` (+0 -3) 📝 `src/Core/Abstractions/ICipherService.cs` (+1 -7) 📝 `src/Core/Services/CipherService.cs` (+1 -21) </details> ### 📄 Description ## Type of change - [ ] Bug fix - [X] New feature development - [ ] Tech debt (refactoring, code cleanup, dependency upgrades, etc) - [ ] Build/deploy pipeline (DevOps) - [ ] Other ## Objective <!--Describe what the purpose of this PR is. For example: what bug you're fixing or what new feature you're adding--> Removed duplicate check when moving a passkey to an organization. ## Code changes <!--Explain the changes you've made to each file or major component. This should help the reviewer understand your changes--> <!--Also refer to any related changes or PRs in other repositories--> * Removed logic that was checking passkey duplication when moving a personal vault passkey to an organization. ## Before you submit - Please check for formatting errors (`dotnet format --verify-no-changes`) (required) - Please add **unit tests** where it makes sense to do so (encouraged but not required) - If this change requires a **documentation update** - notify the documentation team - If this change has particular **deployment requirements** - notify the DevOps team --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-15 02:20:58 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#16585
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?