github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-05-09 05:20:24 -05:00
Code Issues 1.1k Packages Projects Releases 122 Wiki Activity

[PR #2684] [CLOSED] [PM-3424] Make mobile app navigation significantly more responsive during use #16488

New Issue
Closed
opened 2026-04-15 02:17:06 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-15 02:17:06 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/2684
Author: @quexten
Created: 8/12/2023
Status: ❌ Closed

Base: main ← Head: fix/laggy-navigation-performance

📝 Commits (1)

  • 65f9fe3 Remove task delay on content page load

📊 Changes

1 file changed (+0 additions, -1 deletions)

View changed files

📝 src/App/Pages/BaseContentPage.cs (+0 -1)

📄 Description

Type of change

  • Bug fix
  • New feature development
  • Tech debt (refactoring, code cleanup, dependency upgrades, etc)
  • Build/deploy pipeline (DevOps)
  • Other

Objective

On each content page navigation in the mobile app, a significant delay (400ms) occurs in which a loading spinner is shown, even if nothing is loading, making the app feel quite laggy during use. This delay is introduced by a Task.Delay of 400ms on the codepath that displays the content. I'm not quite sure why the delay is so long, by the variable name it is some kind of animation delay, but the transition animation has long finished by the time the delay is done.

Either way, removing the delay seems to cause no issues and makes the app feel much more responsive (see the videos below).

Code changes

  • file.ext: Description of what was changed and why

Screenshots

https://github.com/bitwarden/mobile/assets/11866552/51159fec-a79e-4a2c-b590-97db4adbba97

https://github.com/bitwarden/mobile/assets/11866552/b9320d13-31f8-41a1-882a-50b45f6b7a18

Before you submit

  • Please check for formatting errors (dotnet format --verify-no-changes) (required)
  • Please add unit tests where it makes sense to do so (encouraged but not required)
  • If this change requires a documentation update - notify the documentation team
  • If this change has particular deployment requirements - notify the DevOps team

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/2684 **Author:** [@quexten](https://github.com/quexten) **Created:** 8/12/2023 **Status:** ❌ Closed **Base:** `main` ← **Head:** `fix/laggy-navigation-performance` --- ### 📝 Commits (1) - [`65f9fe3`](https://github.com/bitwarden/android/commit/65f9fe34a1178ce41cf3cb5e9c1666086d4c419f) Remove task delay on content page load ### 📊 Changes **1 file changed** (+0 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `src/App/Pages/BaseContentPage.cs` (+0 -1) </details> ### 📄 Description ## Type of change - [x] Bug fix - [ ] New feature development - [ ] Tech debt (refactoring, code cleanup, dependency upgrades, etc) - [ ] Build/deploy pipeline (DevOps) - [ ] Other ## Objective On each content page navigation in the mobile app, a significant delay (400ms) occurs in which a loading spinner is shown, even if nothing is loading, making the app feel quite laggy during use. This delay is introduced by a `Task.Delay` of 400ms on the codepath that displays the content. I'm not quite sure why the delay is so long, by the variable name it is some kind of animation delay, but the transition animation has long finished by the time the delay is done. Either way, removing the delay seems to cause no issues and makes the app feel much more responsive (see the videos below). ## Code changes <!--Explain the changes you've made to each file or major component. This should help the reviewer understand your changes--> <!--Also refer to any related changes or PRs in other repositories--> * **file.ext:** Description of what was changed and why ## Screenshots https://github.com/bitwarden/mobile/assets/11866552/51159fec-a79e-4a2c-b590-97db4adbba97 https://github.com/bitwarden/mobile/assets/11866552/b9320d13-31f8-41a1-882a-50b45f6b7a18 ## Before you submit - Please check for formatting errors (`dotnet format --verify-no-changes`) (required) - Please add **unit tests** where it makes sense to do so (encouraged but not required) - If this change requires a **documentation update** - notify the documentation team - If this change has particular **deployment requirements** - notify the DevOps team --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-15 02:17:06 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#16488
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?