github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-05-07 11:29:37 -05:00
Code Issues 1.1k Packages Projects Releases 122 Wiki Activity

[PR #2659] [MERGED] [PM-3071] Remove share on save toggle on Send view #16465

New Issue
Closed
opened 2026-04-15 02:16:07 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-15 02:16:07 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/2659
Author: @fedemkr
Created: 8/3/2023
Status: ✅ Merged
Merged: 8/17/2023
Merged by: @fedemkr

Base: master ← Head: vault/pm-3071/update-share-behavior-send

📝 Commits (3)

  • 9554dc6 PM-3071 Removed share on save toggle on Send view and now it's done automatically, same for copy after saving from the Share extension
  • 85469b4 PM-3071 Fix alignments on Share extension send view
  • 3877abb Merge branch 'master' into vault/pm-3071/update-share-behavior-send

📊 Changes

3 files changed (+18 additions, -64 deletions)

View changed files

📝 src/App/Pages/Send/SendAddEditPage.xaml (+3 -17)
📝 src/App/Pages/Send/SendAddEditPageViewModel.cs (+13 -32)
📝 src/App/Pages/Send/SendAddOnlyPage.xaml (+2 -15)

📄 Description

Type of change

  • Bug fix
  • New feature development
  • Tech debt (refactoring, code cleanup, dependency upgrades, etc)
  • Build/deploy pipeline (DevOps)
  • Other

Objective

Update send view to not have the "Share on save" toggle and do it automatically after saving. On the Share extension, the "Copy after save" was removed as well and it's done automatically after saving. Also some UI improvements have been made.

Code changes

  • SendAddEditPage.xaml, SendAddOnlyPage.xaml: Removed Share/Copy toggle and updated alignments.
  • SendAddEditPageViewModel: Updated logic to share/copy automatically after save and removed the "Share on save" flag.

Screenshots

Send Text View Android

Send Text View Android

Send File View Android

Send File View Android

Send Text View iOS

Send Text View iOS

Send File View iOS

Send File View iOS

Before you submit

  • Please check for formatting errors (dotnet format --verify-no-changes) (required)
  • Please add unit tests where it makes sense to do so (encouraged but not required)
  • If this change requires a documentation update - notify the documentation team
  • If this change has particular deployment requirements - notify the DevOps team

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/2659 **Author:** [@fedemkr](https://github.com/fedemkr) **Created:** 8/3/2023 **Status:** ✅ Merged **Merged:** 8/17/2023 **Merged by:** [@fedemkr](https://github.com/fedemkr) **Base:** `master` ← **Head:** `vault/pm-3071/update-share-behavior-send` --- ### 📝 Commits (3) - [`9554dc6`](https://github.com/bitwarden/android/commit/9554dc635b7e83be828c94af1a82a6c65bb1da4c) PM-3071 Removed share on save toggle on Send view and now it's done automatically, same for copy after saving from the Share extension - [`85469b4`](https://github.com/bitwarden/android/commit/85469b4dc4480e5accbf73e88d0186847e245404) PM-3071 Fix alignments on Share extension send view - [`3877abb`](https://github.com/bitwarden/android/commit/3877abb2df6e202f7572a888989d57167a2832c7) Merge branch 'master' into vault/pm-3071/update-share-behavior-send ### 📊 Changes **3 files changed** (+18 additions, -64 deletions) <details> <summary>View changed files</summary> 📝 `src/App/Pages/Send/SendAddEditPage.xaml` (+3 -17) 📝 `src/App/Pages/Send/SendAddEditPageViewModel.cs` (+13 -32) 📝 `src/App/Pages/Send/SendAddOnlyPage.xaml` (+2 -15) </details> ### 📄 Description ## Type of change - [ ] Bug fix - [ ] New feature development - [ ] Tech debt (refactoring, code cleanup, dependency upgrades, etc) - [ ] Build/deploy pipeline (DevOps) - [ ] Other ## Objective <!--Describe what the purpose of this PR is. For example: what bug you're fixing or what new feature you're adding--> Update send view to not have the "Share on save" toggle and do it automatically after saving. On the Share extension, the "Copy after save" was removed as well and it's done automatically after saving. Also some UI improvements have been made. ## Code changes <!--Explain the changes you've made to each file or major component. This should help the reviewer understand your changes--> <!--Also refer to any related changes or PRs in other repositories--> * **SendAddEditPage.xaml, SendAddOnlyPage.xaml:** Removed Share/Copy toggle and updated alignments. * **SendAddEditPageViewModel:** Updated logic to share/copy automatically after save and removed the "Share on save" flag. ## Screenshots <!--Required for any UI changes. Delete if not applicable--> ### Send Text View Android <img width="314" alt="Send Text View Android" src="https://github.com/bitwarden/mobile/assets/15682323/cfaae44e-ed21-4e10-807a-10417dc0313e"> ### Send File View Android <img width="314" alt="Send File View Android" src="https://github.com/bitwarden/mobile/assets/15682323/7de9f293-b0f4-4fee-8dc3-32f859616e46"> ### Send Text View iOS <img width="314" alt="Send Text View iOS" src="https://github.com/bitwarden/mobile/assets/15682323/fd030dd9-d6cb-46f2-a5f4-3a1fe83b197d"> ### Send File View iOS <img width="314" alt="Send File View iOS" src="https://github.com/bitwarden/mobile/assets/15682323/b69ff683-3be0-410a-93ae-af0dc8c8e7bf"> ## Before you submit - Please check for formatting errors (`dotnet format --verify-no-changes`) (required) - Please add **unit tests** where it makes sense to do so (encouraged but not required) - If this change requires a **documentation update** - notify the documentation team - If this change has particular **deployment requirements** - notify the DevOps team --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-15 02:16:07 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#16465
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?