github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-05-06 15:58:22 -05:00
Code Issues 1.1k Packages Projects Releases 122 Wiki Activity

[PR #2558] [MERGED] [PS-2558] Mobile Automation - Starting automationIDs additions to our codebase #16394

New Issue
Closed
opened 2026-04-15 02:13:32 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-15 02:13:32 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/2558
Author: @ifernandezdiaz
Created: 6/5/2023
Status: ✅ Merged
Merged: 6/7/2023
Merged by: @ifernandezdiaz

Base: master ← Head: test/automation-ids-for-login-environment-views

📝 Commits (5)

  • 5f8c972 Adding locators for Environment, Hope, Login and Register pages
  • 3462445 Merge branch 'master' into automation/adding-ids-to-elements
  • 1636227 Adding Locators on LockPage
  • 510fa26 Merge branch 'master' into test/automation-ids-for-login-environment-views
  • 04ab40f Adding Álison's suggestions

📊 Changes

5 files changed (+75 additions, -35 deletions)

View changed files

📝 src/App/Pages/Accounts/EnvironmentPage.xaml (+10 -5)
📝 src/App/Pages/Accounts/HomePage.xaml (+15 -7)
📝 src/App/Pages/Accounts/LockPage.xaml (+11 -5)
📝 src/App/Pages/Accounts/LoginPage.xaml (+24 -11)
📝 src/App/Pages/Accounts/RegisterPage.xaml (+15 -7)

📄 Description

Type of change

  • Bug fix
  • New feature development
  • Tech debt (refactoring, code cleanup, dependency upgrades, etc)
  • Build/deploy pipeline (DevOps)
  • Other

Objective

To improve the reliability of our automated mobile tests, we added AutomationIDs for the most important elements in our mobile app.

Code changes

  • EnvironmentPage.xaml: Locators added for URL fields
  • HomePage.xaml: Locators added for Email field, Continue and Create Account buttons
  • LockPage.xaml: Locators added for Unlock and Toggle Visibility buttons, apart from PIN and Password fields
  • LoginPage.xaml: Locators added for each interactable element.
  • RegisterPage.xaml: Locators added for each interactable element.

Before you submit

  • Please check for formatting errors (dotnet format --verify-no-changes) (required)
  • Please add unit tests where it makes sense to do so (encouraged but not required)
  • If this change requires a documentation update - notify the documentation team
  • If this change has particular deployment requirements - notify the DevOps team

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/2558 **Author:** [@ifernandezdiaz](https://github.com/ifernandezdiaz) **Created:** 6/5/2023 **Status:** ✅ Merged **Merged:** 6/7/2023 **Merged by:** [@ifernandezdiaz](https://github.com/ifernandezdiaz) **Base:** `master` ← **Head:** `test/automation-ids-for-login-environment-views` --- ### 📝 Commits (5) - [`5f8c972`](https://github.com/bitwarden/android/commit/5f8c97214a9f5a8a514a0ac8dcf580f653269bcc) Adding locators for Environment, Hope, Login and Register pages - [`3462445`](https://github.com/bitwarden/android/commit/3462445586fd1c2ffeef121c3584f9fd20d94172) Merge branch 'master' into automation/adding-ids-to-elements - [`1636227`](https://github.com/bitwarden/android/commit/1636227a9cfcaadaa63e4cc57008c557b9d4ba47) Adding Locators on LockPage - [`510fa26`](https://github.com/bitwarden/android/commit/510fa26afbcbd8d923fbdc95d4c3d7f038018aba) Merge branch 'master' into test/automation-ids-for-login-environment-views - [`04ab40f`](https://github.com/bitwarden/android/commit/04ab40f7d919a5893ea650c2664c1b05c24479f1) Adding Álison's suggestions ### 📊 Changes **5 files changed** (+75 additions, -35 deletions) <details> <summary>View changed files</summary> 📝 `src/App/Pages/Accounts/EnvironmentPage.xaml` (+10 -5) 📝 `src/App/Pages/Accounts/HomePage.xaml` (+15 -7) 📝 `src/App/Pages/Accounts/LockPage.xaml` (+11 -5) 📝 `src/App/Pages/Accounts/LoginPage.xaml` (+24 -11) 📝 `src/App/Pages/Accounts/RegisterPage.xaml` (+15 -7) </details> ### 📄 Description ## Type of change - [ ] Bug fix - [ ] New feature development - [ ] Tech debt (refactoring, code cleanup, dependency upgrades, etc) - [ ] Build/deploy pipeline (DevOps) - [X] Other ## Objective To improve the reliability of our automated mobile tests, we added AutomationIDs for the most important elements in our mobile app. ## Code changes * **EnvironmentPage.xaml:** Locators added for URL fields * **HomePage.xaml:** Locators added for `Email` field, `Continue` and `Create Account` buttons * **LockPage.xaml:** Locators added for `Unlock` and `Toggle Visibility` buttons, apart from `PIN` and `Password` fields * **LoginPage.xaml:** Locators added for each interactable element. * **RegisterPage.xaml:** Locators added for each interactable element. ## Before you submit - Please check for formatting errors (`dotnet format --verify-no-changes`) (required) - Please add **unit tests** where it makes sense to do so (encouraged but not required) - If this change requires a **documentation update** - notify the documentation team - If this change has particular **deployment requirements** - notify the DevOps team --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-15 02:13:32 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#16394
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?