github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-05-08 21:10:40 -05:00
Code Issues 1.1k Packages Projects Releases 122 Wiki Activity

[PR #2472] [MERGED] [PM-1731] Using UIDocumentPickerViewController when saving files on iOS #16337

New Issue
Closed
opened 2026-04-15 02:11:30 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-15 02:11:30 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/2472
Author: @aj-rosado
Created: 4/13/2023
Status: ✅ Merged
Merged: 4/13/2023
Merged by: @aj-rosado

Base: master ← Head: bug/PM-1731-save-files-popup-disappear-ios

📝 Commits (1)

  • a1cc831 PM-1731 - Changed UIDocumentInteractionController with UIDocumentPickerViewController

📊 Changes

1 file changed (+13 additions, -5 deletions)

View changed files

📝 src/iOS.Core/Services/FileService.cs (+13 -5)

📄 Description

Type of change

  • Bug fix
  • New feature development
  • Tech debt (refactoring, code cleanup, dependency upgrades, etc)
  • Build/deploy pipeline (DevOps)
  • Other

Objective

Some users are experiencing difficulties when trying to download attachments or exports. After selecting "Save in files" it should show the file system so that the user could select where to save it. Although sometimes it doesn't appear.

Code changes

  • FileService.cs: Changed UIDocumentInteractionController with UIDocumentPickerViewController. This way it opens immediately the "file system" and works consistently.

Before you submit

  • Please check for formatting errors (dotnet format --verify-no-changes) (required)
  • Please add unit tests where it makes sense to do so (encouraged but not required)
  • If this change requires a documentation update - notify the documentation team
  • If this change has particular deployment requirements - notify the DevOps team

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/2472 **Author:** [@aj-rosado](https://github.com/aj-rosado) **Created:** 4/13/2023 **Status:** ✅ Merged **Merged:** 4/13/2023 **Merged by:** [@aj-rosado](https://github.com/aj-rosado) **Base:** `master` ← **Head:** `bug/PM-1731-save-files-popup-disappear-ios` --- ### 📝 Commits (1) - [`a1cc831`](https://github.com/bitwarden/android/commit/a1cc831547916ee3b8955d254047c84f7169ff1d) PM-1731 - Changed UIDocumentInteractionController with UIDocumentPickerViewController ### 📊 Changes **1 file changed** (+13 additions, -5 deletions) <details> <summary>View changed files</summary> 📝 `src/iOS.Core/Services/FileService.cs` (+13 -5) </details> ### 📄 Description ## Type of change - [x] Bug fix - [ ] New feature development - [ ] Tech debt (refactoring, code cleanup, dependency upgrades, etc) - [ ] Build/deploy pipeline (DevOps) - [ ] Other ## Objective Some users are experiencing difficulties when trying to download attachments or exports. After selecting "Save in files" it should show the file system so that the user could select where to save it. Although sometimes it doesn't appear. ## Code changes * **FileService.cs:** Changed `UIDocumentInteractionController` with `UIDocumentPickerViewController`. This way it opens immediately the "file system" and works consistently. ## Before you submit - Please check for formatting errors (`dotnet format --verify-no-changes`) (required) - Please add **unit tests** where it makes sense to do so (encouraged but not required) - If this change requires a **documentation update** - notify the documentation team - If this change has particular **deployment requirements** - notify the DevOps team --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-15 02:11:30 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#16337
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?