github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-06-11 00:56:24 -05:00
Code Issues 2.2k Packages Projects Releases 127 Wiki Activity

[PR #2233] [MERGED] [EC-833] Fix WatchDeviceService registration to be called appropiately #16199

New Issue
Closed
opened 2026-04-15 02:06:32 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-15 02:06:32 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/2233
Author: @fedemkr
Created: 12/12/2022
Status: ✅ Merged
Merged: 12/13/2022
Merged by: @fedemkr

Base: master ← Head: bug/EC-833-fix-late-service-registration

📝 Commits (1)

  • b7053e0 EC-833 fix WatchDeviceService registration to be called from the extensions appropiately

📊 Changes

4 files changed (+12 additions, -9 deletions)

View changed files

📝 src/iOS.Autofill/CredentialProviderViewController.cs (+1 -0)
📝 src/iOS.Core/Utilities/iOSCoreHelpers.cs (+9 -4)
📝 src/iOS.Extension/LoadingViewController.cs (+1 -0)
📝 src/iOS/AppDelegate.cs (+1 -5)

📄 Description

Type of change

  • Bug fix
  • New feature development
  • Tech debt (refactoring, code cleanup, dependency upgrades, etc)
  • Build/deploy pipeline (DevOps)
  • Other

Objective

Fix regression where the iOS autofill extension was not working due to services incorrectly registration.

Code changes

  • iOSCoreHelpers: Moved the IWatchDeviceService registration here on the new method RegisterFinallyBeforeBootstrap intended to be used for stuff that need to be setup before bootstrap and after all the other registrations have been done.
  • AppDelegate: Calls the new RegisterFinallyBeforeBootstrap to setup extra stuff before bootstrap. Moved the watch device service registration there.
  • CredentialProviderViewController: Calls the new RegisterFinallyBeforeBootstrap to setup extra stuff before bootstrap.
  • LoadingViewController: Calls the new RegisterFinallyBeforeBootstrap to setup extra stuff before bootstrap.

Before you submit

  • Please check for formatting errors (dotnet format --verify-no-changes) (required)
  • Please add unit tests where it makes sense to do so (encouraged but not required)
  • If this change requires a documentation update - notify the documentation team
  • If this change has particular deployment requirements - notify the DevOps team

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/2233 **Author:** [@fedemkr](https://github.com/fedemkr) **Created:** 12/12/2022 **Status:** ✅ Merged **Merged:** 12/13/2022 **Merged by:** [@fedemkr](https://github.com/fedemkr) **Base:** `master` ← **Head:** `bug/EC-833-fix-late-service-registration` --- ### 📝 Commits (1) - [`b7053e0`](https://github.com/bitwarden/android/commit/b7053e04e11c7f0ea97deadd4f0e28c666f660ed) EC-833 fix WatchDeviceService registration to be called from the extensions appropiately ### 📊 Changes **4 files changed** (+12 additions, -9 deletions) <details> <summary>View changed files</summary> 📝 `src/iOS.Autofill/CredentialProviderViewController.cs` (+1 -0) 📝 `src/iOS.Core/Utilities/iOSCoreHelpers.cs` (+9 -4) 📝 `src/iOS.Extension/LoadingViewController.cs` (+1 -0) 📝 `src/iOS/AppDelegate.cs` (+1 -5) </details> ### 📄 Description ## Type of change - [X] Bug fix - [ ] New feature development - [ ] Tech debt (refactoring, code cleanup, dependency upgrades, etc) - [ ] Build/deploy pipeline (DevOps) - [ ] Other ## Objective <!--Describe what the purpose of this PR is. For example: what bug you're fixing or what new feature you're adding--> Fix regression where the iOS autofill extension was not working due to services incorrectly registration. ## Code changes <!--Explain the changes you've made to each file or major component. This should help the reviewer understand your changes--> <!--Also refer to any related changes or PRs in other repositories--> * **iOSCoreHelpers:** Moved the `IWatchDeviceService` registration here on the new method `RegisterFinallyBeforeBootstrap` intended to be used for stuff that need to be setup before bootstrap and after all the other registrations have been done. * **AppDelegate:** Calls the new `RegisterFinallyBeforeBootstrap` to setup extra stuff before bootstrap. Moved the watch device service registration there. * **CredentialProviderViewController:** Calls the new `RegisterFinallyBeforeBootstrap` to setup extra stuff before bootstrap. * **LoadingViewController:** Calls the new `RegisterFinallyBeforeBootstrap` to setup extra stuff before bootstrap. ## Before you submit - Please check for formatting errors (`dotnet format --verify-no-changes`) (required) - Please add **unit tests** where it makes sense to do so (encouraged but not required) - If this change requires a **documentation update** - notify the documentation team - If this change has particular **deployment requirements** - notify the DevOps team --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-15 02:06:32 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#16199
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?