github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-06-10 00:28:29 -05:00
Code Issues 2.2k Packages Projects Releases 127 Wiki Activity

[PR #1990] [MERGED] [EC-323] Fix error when getting the first letters on avatar image creation #16029

New Issue
Closed
opened 2026-04-15 02:01:53 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-15 02:01:53 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/1990
Author: @fedemkr
Created: 7/13/2022
Status: ✅ Merged
Merged: 7/14/2022
Merged by: @vvolkgang

Base: master ← Head: bug/EC-323-fix-get-first-letters-on-avatar-creation

📝 Commits (1)

  • 7e7abe3 EC-323 sanitize data on get first letters for avatar image creation

📊 Changes

1 file changed (+10 additions, -7 deletions)

View changed files

📝 src/App/Controls/AvatarImageSource.cs (+10 -7)

📄 Description

Type of change

  • Bug fix
  • New feature development
  • Tech debt (refactoring, code cleanup, dependency upgrades, etc)
  • Build/deploy pipeline (DevOps)
  • Other

Objective

Fix getting the first letters on avatar image creation. There are some cases when more spaces are added, at the beginning, at the end or in the middle that causes the method to fail.

Code changes

  • AvatarImageSource.cs: Sanitized data on getting first letters so that it doesn't fail when more spaces are added

Before you submit

  • I have checked for formatting errors (dotnet tool run dotnet-format --check) (required)
  • I have added unit tests where it makes sense to do so (encouraged but not required)
  • This change requires a documentation update (notify the documentation team)
  • This change has particular deployment requirements (notify the DevOps team)

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/1990 **Author:** [@fedemkr](https://github.com/fedemkr) **Created:** 7/13/2022 **Status:** ✅ Merged **Merged:** 7/14/2022 **Merged by:** [@vvolkgang](https://github.com/vvolkgang) **Base:** `master` ← **Head:** `bug/EC-323-fix-get-first-letters-on-avatar-creation` --- ### 📝 Commits (1) - [`7e7abe3`](https://github.com/bitwarden/android/commit/7e7abe369ea25046adfcca9856c74396be6dcddd) EC-323 sanitize data on get first letters for avatar image creation ### 📊 Changes **1 file changed** (+10 additions, -7 deletions) <details> <summary>View changed files</summary> 📝 `src/App/Controls/AvatarImageSource.cs` (+10 -7) </details> ### 📄 Description ## Type of change - [X] Bug fix - [ ] New feature development - [ ] Tech debt (refactoring, code cleanup, dependency upgrades, etc) - [ ] Build/deploy pipeline (DevOps) - [ ] Other ## Objective <!--Describe what the purpose of this PR is. For example: what bug you're fixing or what new feature you're adding--> Fix getting the first letters on avatar image creation. There are some cases when more spaces are added, at the beginning, at the end or in the middle that causes the method to fail. ## Code changes <!--Explain the changes you've made to each file or major component. This should help the reviewer understand your changes--> <!--Also refer to any related changes or PRs in other repositories--> * **AvatarImageSource.cs:** Sanitized data on getting first letters so that it doesn't fail when more spaces are added ## Before you submit - [X] I have checked for formatting errors (`dotnet tool run dotnet-format --check`) (required) - [ ] I have added **unit tests** where it makes sense to do so (encouraged but not required) - [ ] This change requires a **documentation update** (notify the documentation team) - [ ] This change has particular **deployment requirements** (notify the DevOps team) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-15 02:01:53 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#16029
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?