github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-05-09 21:39:15 -05:00
Code Issues 1.1k Packages Projects Releases 122 Wiki Activity

[PR #1943] [MERGED] [PS-785] Added logs for exceptions on UpdateTemplatedCell #15993

New Issue
Closed
opened 2026-04-15 02:00:59 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-15 02:00:59 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/1943
Author: @fedemkr
Created: 6/6/2022
Status: ✅ Merged
Merged: 6/7/2022
Merged by: @fedemkr

Base: master ← Head: bug/PS-785-add-logs-for-templatedcell-crash

📝 Commits (2)

  • 9847264 PS-785 Added logs for exceptions on UpdateTemplatedCell and the extra data on each ExtendedCollectionView usage
  • bb98eac Merge branch 'master' into bug/PS-785-add-logs-for-templatedcell-crash

📊 Changes

13 files changed (+68 additions, -11 deletions)

View changed files

📝 src/App/Controls/ExtendedCollectionView.cs (+1 -0)
📝 src/App/Pages/Generator/GeneratorHistoryPage.xaml (+2 -1)
📝 src/App/Pages/Send/SendGroupingsPage/SendGroupingsPage.xaml (+3 -2)
📝 src/App/Pages/Send/SendsPage.xaml (+3 -2)
📝 src/App/Pages/Settings/FoldersPage.xaml (+2 -1)
📝 src/App/Pages/Settings/SettingsPage/SettingsPage.xaml (+2 -1)
📝 src/App/Pages/Vault/AutofillCiphersPage.xaml (+2 -1)
📝 src/App/Pages/Vault/CiphersPage.xaml (+2 -1)
📝 src/App/Pages/Vault/GroupingsPage/GroupingsPage.xaml (+2 -1)
📝 src/App/Pages/Vault/PasswordHistoryPage.xaml (+2 -1)
➕ src/iOS.Core/Renderers/CollectionView/ExtendedCollectionViewRenderer.cs (+16 -0)
➕ src/iOS.Core/Renderers/CollectionView/ExtendedGroupableItemsViewController.cs (+28 -0)
📝 src/iOS.Core/iOS.Core.csproj (+3 -0)

📄 Description

Type of change

  • Bug fix
  • New feature development
  • [] Tech debt (refactoring, code cleanup, dependency upgrades, etc)
  • Build/deploy pipeline (DevOps)
  • Other

Objective

Add extended logs for CollectionView on iOS when doing UpdateTemplatedCell to have more context on the AppCenter crashes.

Code changes

  • ExtendedCollectionView.cs: Added ExtraDataForLogging property to add any extra information we want from the usage of the collection view.
  • ExtendedCollectionViewRenderer.cs: Added this renderer in order to override the controller used in the collection view renderer.
  • ExtendedGroupableItemsViewController.cs: Added this to override the UpdateTemplatedCell method and add a try...catch to extend the logging information with the one provided by ExtraDataForLogging to have more context on AppCenter crashes.

Before you submit

  • I have checked for formatting errors (dotnet tool run dotnet-format --check) (required)
  • I have added unit tests where it makes sense to do so (encouraged but not required)
  • This change requires a documentation update (notify the documentation team)
  • This change has particular deployment requirements (notify the DevOps team)

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/1943 **Author:** [@fedemkr](https://github.com/fedemkr) **Created:** 6/6/2022 **Status:** ✅ Merged **Merged:** 6/7/2022 **Merged by:** [@fedemkr](https://github.com/fedemkr) **Base:** `master` ← **Head:** `bug/PS-785-add-logs-for-templatedcell-crash` --- ### 📝 Commits (2) - [`9847264`](https://github.com/bitwarden/android/commit/984726442204767687ea00e4f393d259227245f5) PS-785 Added logs for exceptions on UpdateTemplatedCell and the extra data on each ExtendedCollectionView usage - [`bb98eac`](https://github.com/bitwarden/android/commit/bb98eac74eb80f145beb4f96d987123c63d4e79d) Merge branch 'master' into bug/PS-785-add-logs-for-templatedcell-crash ### 📊 Changes **13 files changed** (+68 additions, -11 deletions) <details> <summary>View changed files</summary> 📝 `src/App/Controls/ExtendedCollectionView.cs` (+1 -0) 📝 `src/App/Pages/Generator/GeneratorHistoryPage.xaml` (+2 -1) 📝 `src/App/Pages/Send/SendGroupingsPage/SendGroupingsPage.xaml` (+3 -2) 📝 `src/App/Pages/Send/SendsPage.xaml` (+3 -2) 📝 `src/App/Pages/Settings/FoldersPage.xaml` (+2 -1) 📝 `src/App/Pages/Settings/SettingsPage/SettingsPage.xaml` (+2 -1) 📝 `src/App/Pages/Vault/AutofillCiphersPage.xaml` (+2 -1) 📝 `src/App/Pages/Vault/CiphersPage.xaml` (+2 -1) 📝 `src/App/Pages/Vault/GroupingsPage/GroupingsPage.xaml` (+2 -1) 📝 `src/App/Pages/Vault/PasswordHistoryPage.xaml` (+2 -1) ➕ `src/iOS.Core/Renderers/CollectionView/ExtendedCollectionViewRenderer.cs` (+16 -0) ➕ `src/iOS.Core/Renderers/CollectionView/ExtendedGroupableItemsViewController.cs` (+28 -0) 📝 `src/iOS.Core/iOS.Core.csproj` (+3 -0) </details> ### 📄 Description ## Type of change - [ ] Bug fix - [ ] New feature development - [] Tech debt (refactoring, code cleanup, dependency upgrades, etc) - [ ] Build/deploy pipeline (DevOps) - [X] Other ## Objective <!--Describe what the purpose of this PR is. For example: what bug you're fixing or what new feature you're adding--> Add extended logs for `CollectionView` on iOS when doing `UpdateTemplatedCell` to have more context on the AppCenter crashes. ## Code changes <!--Explain the changes you've made to each file or major component. This should help the reviewer understand your changes--> <!--Also refer to any related changes or PRs in other repositories--> * **ExtendedCollectionView.cs:** Added `ExtraDataForLogging` property to add any extra information we want from the usage of the collection view. * **ExtendedCollectionViewRenderer.cs:** Added this renderer in order to override the controller used in the collection view renderer. * **ExtendedGroupableItemsViewController.cs:** Added this to override the `UpdateTemplatedCell` method and add a try...catch to extend the logging information with the one provided by `ExtraDataForLogging` to have more context on AppCenter crashes. ## Before you submit - [X] I have checked for formatting errors (`dotnet tool run dotnet-format --check`) (required) - [ ] I have added **unit tests** where it makes sense to do so (encouraged but not required) - [ ] This change requires a **documentation update** (notify the documentation team) - [ ] This change has particular **deployment requirements** (notify the DevOps team) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-15 02:00:59 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#15993
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?