github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-05-10 05:49:44 -05:00
Code Issues 1.1k Packages Projects Releases 122 Wiki Activity

[PR #1852] [MERGED] Fixed flickering on iOS while loading collections #15934

New Issue
Closed
opened 2026-04-15 01:58:59 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-15 01:58:59 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/1852
Author: @fedemkr
Created: 3/18/2022
Status: ✅ Merged
Merged: 3/18/2022
Merged by: @fedemkr

Base: master ← Head: fix-ios-weird-load-animation

📝 Commits (1)

  • bbc04d1 Fixed flickering on iOS while loading collections for the collection crash hotfix

📊 Changes

4 files changed (+97 additions, -36 deletions)

View changed files

📝 src/App/Pages/Send/SendGroupingsPage/SendGroupingsPageViewModel.cs (+24 -8)
📝 src/App/Pages/Settings/SettingsPage/SettingsPageViewModel.cs (+25 -12)
📝 src/App/Pages/Vault/AutofillCiphersPageViewModel.cs (+24 -8)
📝 src/App/Pages/Vault/GroupingsPage/GroupingsPageViewModel.cs (+24 -8)

📄 Description

Type of change

  • Bug fix
  • New feature development
  • Tech debt (refactoring, code cleanup, dependency upgrades, etc)
  • Build/deploy pipeline (DevOps)
  • Other

Objective

Hotfix of flickering on iOS while loading collections due to collections crash hotfix #1850

Code changes

  • ...ViewModel: Changed the code to only make special loading of the list if it's coming from an empty state. If so, first the list is replaced with the header and the all the items are loaded. If it's not empty, then the whole list is replaced at once.

Testing requirements

Test that Vault items, Send items, Settings and Autofill ciphers list are loading correctly even if you remove all items so that the list gets empty and also when the list is empty add a new item and test that the app behaves as expected without crashing.

Before you submit

  • I have added unit tests where it makes sense to do so (encouraged but not required)
  • This change requires a documentation update (notify the documentation team)
  • This change has particular deployment requirements (notify the DevOps team)

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/1852 **Author:** [@fedemkr](https://github.com/fedemkr) **Created:** 3/18/2022 **Status:** ✅ Merged **Merged:** 3/18/2022 **Merged by:** [@fedemkr](https://github.com/fedemkr) **Base:** `master` ← **Head:** `fix-ios-weird-load-animation` --- ### 📝 Commits (1) - [`bbc04d1`](https://github.com/bitwarden/android/commit/bbc04d1c3d4fb6208041b6316c72851cd5b53d19) Fixed flickering on iOS while loading collections for the collection crash hotfix ### 📊 Changes **4 files changed** (+97 additions, -36 deletions) <details> <summary>View changed files</summary> 📝 `src/App/Pages/Send/SendGroupingsPage/SendGroupingsPageViewModel.cs` (+24 -8) 📝 `src/App/Pages/Settings/SettingsPage/SettingsPageViewModel.cs` (+25 -12) 📝 `src/App/Pages/Vault/AutofillCiphersPageViewModel.cs` (+24 -8) 📝 `src/App/Pages/Vault/GroupingsPage/GroupingsPageViewModel.cs` (+24 -8) </details> ### 📄 Description ## Type of change - [X] Bug fix - [ ] New feature development - [ ] Tech debt (refactoring, code cleanup, dependency upgrades, etc) - [ ] Build/deploy pipeline (DevOps) - [ ] Other ## Objective <!--Describe what the purpose of this PR is. For example: what bug you're fixing or what new feature you're adding--> Hotfix of flickering on iOS while loading collections due to collections crash hotfix #1850 ## Code changes <!--Explain the changes you've made to each file or major component. This should help the reviewer understand your changes--> <!--Also refer to any related changes or PRs in other repositories--> * **...ViewModel:** Changed the code to only make special loading of the list if it's coming from an empty state. If so, first the list is replaced with the header and the all the items are loaded. If it's not empty, then the whole list is replaced at once. ## Testing requirements <!--What functionality requires testing by QA? This includes testing new behavior and regression testing--> Test that Vault items, Send items, Settings and Autofill ciphers list are loading correctly even if you remove all items so that the list gets empty and also when the list is empty add a new item and test that the app behaves as expected without crashing. ## Before you submit - [ ] I have added **unit tests** where it makes sense to do so (encouraged but not required) - [ ] This change requires a **documentation update** (notify the documentation team) - [ ] This change has particular **deployment requirements** (notify the DevOps team) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-15 01:58:59 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#15934
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?