github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-05-13 15:21:11 -05:00
Code Issues 1.1k Packages Projects Releases 124 Wiki Activity

[PR #1827] [MERGED] [Captcha] Implement for 2fa #15913

New Issue
Closed
opened 2026-04-15 01:58:15 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-15 01:58:15 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/1827
Author: @vincentsalucci
Created: 3/4/2022
Status: ✅ Merged
Merged: 3/7/2022
Merged by: @vincentsalucci

Base: master ← Head: feature/2fa-captcha

📝 Commits (1)

  • af3d157 [Captcha] Implement for 2fa

📊 Changes

3 files changed (+30 additions, -5 deletions)

View changed files

📝 src/App/Pages/Accounts/TwoFactorPageViewModel.cs (+24 -3)
📝 src/Core/Abstractions/IAuthService.cs (+1 -1)
📝 src/Core/Services/AuthService.cs (+5 -1)

📄 Description

Type of change

  • Bug fix
  • New feature development
  • Tech debt (refactoring, code cleanup, dependency upgrades, etc)
  • Build/deploy pipeline (DevOps)
  • Other

Objective

Implement captcha functionality for the 2fa page

Code changes

  • TwoFactorPageViewModel.cs: Added captcha functionality by using the existing CaptchaProtectedViewModel
  • AuthService: Expanded LogInTwoFactorAsync method to take in potentially passed in captchaToken. Will only overwrite the existing property if the passed in value is not null.

Testing requirements

  • Make sure captcha can be triggered/collected from the 2fa component and complete a successful login

Before you submit

  • I have added unit tests where it makes sense to do so (encouraged but not required)
  • This change requires a documentation update (notify the documentation team)
  • This change has particular deployment requirements (notify the DevOps team)

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/1827 **Author:** [@vincentsalucci](https://github.com/vincentsalucci) **Created:** 3/4/2022 **Status:** ✅ Merged **Merged:** 3/7/2022 **Merged by:** [@vincentsalucci](https://github.com/vincentsalucci) **Base:** `master` ← **Head:** `feature/2fa-captcha` --- ### 📝 Commits (1) - [`af3d157`](https://github.com/bitwarden/android/commit/af3d15757c6966671a54b321aa5170d89e86f362) [Captcha] Implement for 2fa ### 📊 Changes **3 files changed** (+30 additions, -5 deletions) <details> <summary>View changed files</summary> 📝 `src/App/Pages/Accounts/TwoFactorPageViewModel.cs` (+24 -3) 📝 `src/Core/Abstractions/IAuthService.cs` (+1 -1) 📝 `src/Core/Services/AuthService.cs` (+5 -1) </details> ### 📄 Description ## Type of change - [ ] Bug fix - [X] New feature development - [ ] Tech debt (refactoring, code cleanup, dependency upgrades, etc) - [ ] Build/deploy pipeline (DevOps) - [ ] Other ## Objective > Implement `captcha` functionality for the `2fa` page ## Code changes - **TwoFactorPageViewModel.cs:** Added captcha functionality by using the existing `CaptchaProtectedViewModel` - **AuthService**: Expanded `LogInTwoFactorAsync` method to take in potentially passed in `captchaToken`. Will only overwrite the existing property if the passed in value is not null. ## Testing requirements - Make sure captcha can be triggered/collected from the 2fa component and complete a successful login ## Before you submit - [ ] I have added **unit tests** where it makes sense to do so (encouraged but not required) - [X] This change requires a **documentation update** (notify the documentation team) - [ ] This change has particular **deployment requirements** (notify the DevOps team) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-15 01:58:16 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#15913
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?