github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-06-09 16:21:19 -05:00
Code Issues 2.2k Packages Projects Releases 127 Wiki Activity

[PR #1817] [MERGED] Bump target framework to netcoreapp3.1 #15905

New Issue
Closed
opened 2026-04-15 01:57:55 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-15 01:57:55 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/1817
Author: @djsmith85
Created: 2/28/2022
Status: ✅ Merged
Merged: 2/28/2022
Merged by: @mimartin12

Base: master ← Head: bump-publisher-to-net-3.1

📝 Commits (7)

📊 Changes

2 files changed (+2 additions, -2 deletions)

View changed files

📝 .github/workflows/build.yml (+1 -1)
📝 store/google/Publisher/Publisher.csproj (+1 -1)

📄 Description

Type of change

  • Bug fix
  • New feature development
  • Tech debt (refactoring, code cleanup, dependency upgrades, etc)
  • Build/deploy pipeline (DevOps)
  • Other

Objective

The latest master builds are failing as it can't publish to the Play Store. This is due to a dependency on Net Core 2.0 which is not present in the Github Actions.

This PR bumps the target framework of the Google Play Store Publisher from netcoreapp2.1 to netcoreapp3.1.

Code changes

  • store/google/Publisher/Publisher.csproj: Use netcoreapp3.1 instead of netcoreapp2.0

Before you submit

  • I have added unit tests where it makes sense to do so (encouraged but not required)
  • This change requires a documentation update (notify the documentation team)
  • This change has particular deployment requirements (notify the DevOps team)

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/1817 **Author:** [@djsmith85](https://github.com/djsmith85) **Created:** 2/28/2022 **Status:** ✅ Merged **Merged:** 2/28/2022 **Merged by:** [@mimartin12](https://github.com/mimartin12) **Base:** `master` ← **Head:** `bump-publisher-to-net-3.1` --- ### 📝 Commits (7) - [`0214216`](https://github.com/bitwarden/android/commit/02142164564767da40307a6ccbc9f3de2f3938a7) Bump target framework to netcoreapp3.1 - [`f10eed3`](https://github.com/bitwarden/android/commit/f10eed3a8fab1fbed61de7078138dc98a97bdd8a) Updated workflow for testing - [`68059c0`](https://github.com/bitwarden/android/commit/68059c0708f17a74c2a8db7fe367c88aee4fb18e) commit to trigger build - [`f889d99`](https://github.com/bitwarden/android/commit/f889d9929ef3cb7cefa982d4506e657012bdadd9) Execute correct version of publisher - [`18805b8`](https://github.com/bitwarden/android/commit/18805b8d06c49ed1d5af8a0d46e14bacf2375c0f) Merge branch 'bump-publisher-to-net-3.1' of https://github.com/bitwarden/mobile into bump-publisher-to-net-3.1 - [`0fc219d`](https://github.com/bitwarden/android/commit/0fc219da5518dfe225d3e103078df50c66676605) Trigger build - [`338fcd8`](https://github.com/bitwarden/android/commit/338fcd8b39f58bebd28ae222c07166d45105c3de) reverted testing logic ### 📊 Changes **2 files changed** (+2 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `.github/workflows/build.yml` (+1 -1) 📝 `store/google/Publisher/Publisher.csproj` (+1 -1) </details> ### 📄 Description ## Type of change - [X] Bug fix - [ ] New feature development - [ ] Tech debt (refactoring, code cleanup, dependency upgrades, etc) - [ ] Build/deploy pipeline (DevOps) - [ ] Other ## Objective The latest master builds are failing as it can't publish to the Play Store. This is due to a dependency on Net Core 2.0 which is not present in the Github Actions. This PR bumps the target framework of the Google Play Store Publisher from `netcoreapp2.1` to `netcoreapp3.1`. <!--Describe what the purpose of this PR is. For example: what bug you're fixing or what new feature you're adding--> ## Code changes * **store/google/Publisher/Publisher.csproj:** Use netcoreapp3.1 instead of netcoreapp2.0 ## Before you submit - [ ] I have added **unit tests** where it makes sense to do so (encouraged but not required) - [ ] This change requires a **documentation update** (notify the documentation team) - [ ] This change has particular **deployment requirements** (notify the DevOps team) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-15 01:57:55 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#15905
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?