github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-05-08 04:16:40 -05:00
Code Issues 1.1k Packages Projects Releases 122 Wiki Activity

[PR #1728] [MERGED] Fix icon update on Verify code view #15829

New Issue
Closed
opened 2026-04-15 01:55:22 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-15 01:55:22 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/1728
Author: @fedemkr
Created: 1/24/2022
Status: ✅ Merged
Merged: 1/24/2022
Merged by: @fedemkr

Base: master ← Head: fix-account-delete-sso-cme-icons

📝 Commits (1)

  • f80981d Fix icon update on verify code view

📊 Changes

2 files changed (+3 additions, -2 deletions)

View changed files

📝 src/App/Pages/Accounts/VerificationCodePage.xaml (+1 -1)
📝 src/App/Pages/Accounts/VerificationCodeViewModel.cs (+2 -1)

📄 Description

Type of change

  • Bug fix
  • New feature development
  • Tech debt (refactoring, code cleanup, dependency upgrades, etc)
  • Build/deploy pipeline (DevOps)
  • Other

Objective

Fix master build fail because control not existing anymore to show icons.

Code changes

  • VerificationCodePage.xaml: Changed to new control to show icons
  • VerificationCodeViiewModel.cs: Updated code to show the correct icon with the new way

Testing requirements

Same as #1721

Before you submit

  • I have added unit tests where it makes sense to do so (encouraged but not required)
  • This change requires a documentation update (notify the documentation team)
  • This change has particular deployment requirements (notify the DevOps team)

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/1728 **Author:** [@fedemkr](https://github.com/fedemkr) **Created:** 1/24/2022 **Status:** ✅ Merged **Merged:** 1/24/2022 **Merged by:** [@fedemkr](https://github.com/fedemkr) **Base:** `master` ← **Head:** `fix-account-delete-sso-cme-icons` --- ### 📝 Commits (1) - [`f80981d`](https://github.com/bitwarden/android/commit/f80981dde25613b1ce09855c749c6e2e7961113d) Fix icon update on verify code view ### 📊 Changes **2 files changed** (+3 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `src/App/Pages/Accounts/VerificationCodePage.xaml` (+1 -1) 📝 `src/App/Pages/Accounts/VerificationCodeViewModel.cs` (+2 -1) </details> ### 📄 Description ## Type of change - [ ] Bug fix - [ ] New feature development - [X] Tech debt (refactoring, code cleanup, dependency upgrades, etc) - [ ] Build/deploy pipeline (DevOps) - [ ] Other ## Objective <!--Describe what the purpose of this PR is. For example: what bug you're fixing or what new feature you're adding--> Fix master build fail because control not existing anymore to show icons. ## Code changes <!--Explain the changes you've made to each file or major component. This should help the reviewer understand your changes--> <!--Also refer to any related changes or PRs in other repositories--> * **VerificationCodePage.xaml:** Changed to new control to show icons * **VerificationCodeViiewModel.cs:** Updated code to show the correct icon with the new way ## Testing requirements <!--What functionality requires testing by QA? This includes testing new behavior and regression testing--> Same as #1721 ## Before you submit - [ ] I have added **unit tests** where it makes sense to do so (encouraged but not required) - [ ] This change requires a **documentation update** (notify the documentation team) - [ ] This change has particular **deployment requirements** (notify the DevOps team) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-15 01:55:22 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#15829
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?