github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-06-20 20:47:48 -05:00
Code Issues 2.4k Packages Projects Releases 129 Wiki Activity

[PR #1568] [MERGED] Set cursor position after toggle password visibility #15721

New Issue
Closed
opened 2026-04-15 01:52:26 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-15 01:52:26 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/1568
Author: @jlf0dev
Created: 10/8/2021
Status: ✅ Merged
Merged: 10/8/2021
Merged by: @jlf0dev

Base: master ← Head: bug/password-visible-cursor

📝 Commits (1)

  • 138c245 Set cursor position after toggle password visibility

📊 Changes

3 files changed (+10 additions, -3 deletions)

View changed files

📝 src/App/Pages/Accounts/LockPageViewModel.cs (+1 -0)
📝 src/App/Pages/Accounts/LoginPageViewModel.cs (+3 -1)
📝 src/App/Pages/Accounts/RegisterPageViewModel.cs (+6 -2)

📄 Description

Issue

On Android, the cursor for passwords was being reset to the beginning of the text after the visibility was toggled with the eye icon.

Fix

Set the cursor position to the end of the text after visibility toggle for the following pages:

  • Lock page
  • Login page
  • Register page

Closes #1139

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/1568 **Author:** [@jlf0dev](https://github.com/jlf0dev) **Created:** 10/8/2021 **Status:** ✅ Merged **Merged:** 10/8/2021 **Merged by:** [@jlf0dev](https://github.com/jlf0dev) **Base:** `master` ← **Head:** `bug/password-visible-cursor` --- ### 📝 Commits (1) - [`138c245`](https://github.com/bitwarden/android/commit/138c2456b3c879e2c1a51aa7fa100bffdf14b072) Set cursor position after toggle password visibility ### 📊 Changes **3 files changed** (+10 additions, -3 deletions) <details> <summary>View changed files</summary> 📝 `src/App/Pages/Accounts/LockPageViewModel.cs` (+1 -0) 📝 `src/App/Pages/Accounts/LoginPageViewModel.cs` (+3 -1) 📝 `src/App/Pages/Accounts/RegisterPageViewModel.cs` (+6 -2) </details> ### 📄 Description ## Issue On Android, the cursor for passwords was being reset to the beginning of the text after the visibility was toggled with the eye icon. ## Fix Set the cursor position to the end of the text after visibility toggle for the following pages: - Lock page - Login page - Register page Closes #1139 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-15 01:52:26 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#15721
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?