github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-05-05 23:38:51 -05:00
Code Issues 1.1k Packages Projects Releases 122 Wiki Activity

[PR #1149] [MERGED] [GDPR] Updated privacy policy links for theming #15523

New Issue
Closed
opened 2026-04-15 01:46:32 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-15 01:46:32 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/1149
Author: @vincentsalucci
Created: 11/13/2020
Status: ✅ Merged
Merged: 11/13/2020
Merged by: @vincentsalucci

Base: master ← Head: m-gdpr-theme

📝 Commits (1)

  • 48df62d Updated privacy policy links for theming

📊 Changes

5 files changed (+10 additions, -2 deletions)

View changed files

📝 src/App/Pages/Accounts/RegisterPage.xaml (+2 -2)
📝 src/App/Styles/Black.xaml (+2 -0)
📝 src/App/Styles/Dark.xaml (+2 -0)
📝 src/App/Styles/Light.xaml (+2 -0)
📝 src/App/Styles/Nord.xaml (+2 -0)

📄 Description

Objective

Hyperlinks needs to be updated with proper theming

Code Changes

  • RegisterPage.xaml: Adjusted TextColor to use static resource colors established in all themes
  • Styles: Added HyperlinkColor that mimics existing color schemes

Screenshots

mobile-0-gdpr-dark
mobile-1-gdpr-black
mobile-2-gdpr-nord

Shoutout to @vachan-maker for the heads up 👍

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/1149 **Author:** [@vincentsalucci](https://github.com/vincentsalucci) **Created:** 11/13/2020 **Status:** ✅ Merged **Merged:** 11/13/2020 **Merged by:** [@vincentsalucci](https://github.com/vincentsalucci) **Base:** `master` ← **Head:** `m-gdpr-theme` --- ### 📝 Commits (1) - [`48df62d`](https://github.com/bitwarden/android/commit/48df62dca081396fa773a3fbb6392b46acdbd345) Updated privacy policy links for theming ### 📊 Changes **5 files changed** (+10 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `src/App/Pages/Accounts/RegisterPage.xaml` (+2 -2) 📝 `src/App/Styles/Black.xaml` (+2 -0) 📝 `src/App/Styles/Dark.xaml` (+2 -0) 📝 `src/App/Styles/Light.xaml` (+2 -0) 📝 `src/App/Styles/Nord.xaml` (+2 -0) </details> ### 📄 Description ## Objective > Hyperlinks needs to be updated with proper theming ## Code Changes - **RegisterPage.xaml**: Adjusted `TextColor` to use static resource colors established in all themes - **Styles**: Added `HyperlinkColor` that mimics existing color schemes ## Screenshots ![mobile-0-gdpr-dark](https://user-images.githubusercontent.com/26154748/99107056-da2d4500-25aa-11eb-814c-37f9477d247c.png) ![mobile-1-gdpr-black](https://user-images.githubusercontent.com/26154748/99107058-dbf70880-25aa-11eb-8bf9-19e364ef142b.png) ![mobile-2-gdpr-nord](https://user-images.githubusercontent.com/26154748/99107060-dc8f9f00-25aa-11eb-8c0e-6e17026a82f9.png) Shoutout to @vachan-maker for the heads up 👍 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-15 01:46:32 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#15523
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?