github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-05-07 19:39:41 -05:00
Code Issues 1.1k Packages Projects Releases 122 Wiki Activity

[PR #859] [MERGED] [Soft Delete] - Fix for iOS autofill index behavior #15374

New Issue
Closed
opened 2026-04-15 01:41:27 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-15 01:41:27 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/859
Author: @cscharf
Created: 4/29/2020
Status: ✅ Merged
Merged: 4/29/2020
Merged by: @cscharf

Base: soft-delete ← Head: soft-delete-init

📝 Commits (3)

  • 1c748cc [Soft Delete] Added trash folder to mobile
  • aeaa43a [Soft Delete] - Revert send to trash label
  • 4a45d8a [Soft Delete] - iOS autofill index behavior fix

📊 Changes

25 files changed (+373 additions, -40 deletions)

View changed files

📝 src/App/Pages/Vault/AddEditPageViewModel.cs (+6 -5)
📝 src/App/Pages/Vault/CiphersPage.xaml.cs (+7 -2)
📝 src/App/Pages/Vault/CiphersPageViewModel.cs (+3 -1)
📝 src/App/Pages/Vault/GroupingsPage/GroupingsPage.xaml.cs (+22 -4)
📝 src/App/Pages/Vault/GroupingsPage/GroupingsPageListItem.cs (+11 -2)
📝 src/App/Pages/Vault/GroupingsPage/GroupingsPageViewModel.cs (+39 -6)
📝 src/App/Pages/Vault/ViewPage.xaml (+3 -2)
📝 src/App/Pages/Vault/ViewPage.xaml.cs (+26 -2)
📝 src/App/Pages/Vault/ViewPageViewModel.cs (+57 -5)
📝 src/App/Resources/AppResources.Designer.cs (+67 -0)
📝 src/App/Resources/AppResources.resx (+43 -0)
📝 src/App/Utilities/AppHelpers.cs (+5 -1)
📝 src/Core/Abstractions/IApiService.cs (+2 -0)
📝 src/Core/Abstractions/ICipherService.cs (+3 -1)
📝 src/Core/Abstractions/ISearchService.cs (+3 -3)
📝 src/Core/Enums/EventType.cs (+2 -0)
📝 src/Core/Models/Data/CipherData.cs (+2 -0)
📝 src/Core/Models/Domain/Cipher.cs (+5 -1)
📝 src/Core/Models/Response/CipherResponse.cs (+1 -0)
📝 src/Core/Models/View/CipherView.cs (+3 -0)

...and 5 more files

📄 Description

From prior PR comments, tested and working as expected with suggested changes.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/859 **Author:** [@cscharf](https://github.com/cscharf) **Created:** 4/29/2020 **Status:** ✅ Merged **Merged:** 4/29/2020 **Merged by:** [@cscharf](https://github.com/cscharf) **Base:** `soft-delete` ← **Head:** `soft-delete-init` --- ### 📝 Commits (3) - [`1c748cc`](https://github.com/bitwarden/android/commit/1c748cc7ca5620e1a9942f998d0e056d4cfd718b) [Soft Delete] Added trash folder to mobile - [`aeaa43a`](https://github.com/bitwarden/android/commit/aeaa43af5a91c0b630b2a97bcd933e70a2b957af) [Soft Delete] - Revert send to trash label - [`4a45d8a`](https://github.com/bitwarden/android/commit/4a45d8af545c88c138f8641d1f09305bf873c34e) [Soft Delete] - iOS autofill index behavior fix ### 📊 Changes **25 files changed** (+373 additions, -40 deletions) <details> <summary>View changed files</summary> 📝 `src/App/Pages/Vault/AddEditPageViewModel.cs` (+6 -5) 📝 `src/App/Pages/Vault/CiphersPage.xaml.cs` (+7 -2) 📝 `src/App/Pages/Vault/CiphersPageViewModel.cs` (+3 -1) 📝 `src/App/Pages/Vault/GroupingsPage/GroupingsPage.xaml.cs` (+22 -4) 📝 `src/App/Pages/Vault/GroupingsPage/GroupingsPageListItem.cs` (+11 -2) 📝 `src/App/Pages/Vault/GroupingsPage/GroupingsPageViewModel.cs` (+39 -6) 📝 `src/App/Pages/Vault/ViewPage.xaml` (+3 -2) 📝 `src/App/Pages/Vault/ViewPage.xaml.cs` (+26 -2) 📝 `src/App/Pages/Vault/ViewPageViewModel.cs` (+57 -5) 📝 `src/App/Resources/AppResources.Designer.cs` (+67 -0) 📝 `src/App/Resources/AppResources.resx` (+43 -0) 📝 `src/App/Utilities/AppHelpers.cs` (+5 -1) 📝 `src/Core/Abstractions/IApiService.cs` (+2 -0) 📝 `src/Core/Abstractions/ICipherService.cs` (+3 -1) 📝 `src/Core/Abstractions/ISearchService.cs` (+3 -3) 📝 `src/Core/Enums/EventType.cs` (+2 -0) 📝 `src/Core/Models/Data/CipherData.cs` (+2 -0) 📝 `src/Core/Models/Domain/Cipher.cs` (+5 -1) 📝 `src/Core/Models/Response/CipherResponse.cs` (+1 -0) 📝 `src/Core/Models/View/CipherView.cs` (+3 -0) _...and 5 more files_ </details> ### 📄 Description From prior PR comments, tested and working as expected with suggested changes. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-15 01:41:27 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#15374
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?