github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-05-09 05:20:24 -05:00
Code Issues 1.1k Packages Projects Releases 122 Wiki Activity

[PR #795] [MERGED] Added Quick Settings tile for triggering accessibility autofill #15344

New Issue
Closed
opened 2026-04-15 01:40:29 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-15 01:40:29 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/795
Author: @mpbw2
Created: 3/25/2020
Status: ✅ Merged
Merged: 3/26/2020
Merged by: @mpbw2

Base: master ← Head: feature-autofill-tile

📝 Commits (3)

  • 79dc884 Added Quick Settings tile for triggering accessibility autofill
  • 6f0eb6b Fix crash when tile attempt to cancel non-visible but non-null overlay
  • 946752c Persist tile state plus cleanup

📊 Changes

9 files changed (+205 additions, -6 deletions)

View changed files

📝 src/Android/Accessibility/AccessibilityActivity.cs (+19 -2)
📝 src/Android/Accessibility/AccessibilityHelpers.cs (+2 -0)
📝 src/Android/Accessibility/AccessibilityService.cs (+66 -4)
📝 src/Android/Android.csproj (+1 -0)
📝 src/Android/Resources/values/strings.xml (+3 -0)
➕ src/Android/Tiles/AutofillTileService.cs (+95 -0)
📝 src/App/Resources/AppResources.Designer.cs (+12 -0)
📝 src/App/Resources/AppResources.resx (+6 -0)
📝 src/Core/Constants.cs (+1 -0)

📄 Description

The user can now add a "scan & fill" quick setting tile on Android 7.0+ via the Android's tile edit/config mechanism. It uses accessibility to perform the autofill and can be used in addition to, or in lieu of, the accessibility overlay (by leaving the overlay permission disabled they can safely use the tile only - the missing-overlay-permission toast only appears if the tile isn't enabled).

Fun stuff:

  • You can only collapse the quick settings dropdown by launching an activity or opening a dialog. Once I accepted defeat here I resorted to using a dialog for the "you need to enable accessibility" error, and an activity to trigger the broadcast message to the accessibility service to perform a field search.
  • Without waiting 250ms after receiving the trigger message, the window parser would routinely only see the system UI which we ignore by default. Can't beat a good nap.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/795 **Author:** [@mpbw2](https://github.com/mpbw2) **Created:** 3/25/2020 **Status:** ✅ Merged **Merged:** 3/26/2020 **Merged by:** [@mpbw2](https://github.com/mpbw2) **Base:** `master` ← **Head:** `feature-autofill-tile` --- ### 📝 Commits (3) - [`79dc884`](https://github.com/bitwarden/android/commit/79dc884a9ed4bd2d1f6097ef505450dc95a3c949) Added Quick Settings tile for triggering accessibility autofill - [`6f0eb6b`](https://github.com/bitwarden/android/commit/6f0eb6b0cde581aabfa6bcfded0ab9153bf6524f) Fix crash when tile attempt to cancel non-visible but non-null overlay - [`946752c`](https://github.com/bitwarden/android/commit/946752c9ff7c0e0e5cc2c43905ed90cf53cc60b8) Persist tile state plus cleanup ### 📊 Changes **9 files changed** (+205 additions, -6 deletions) <details> <summary>View changed files</summary> 📝 `src/Android/Accessibility/AccessibilityActivity.cs` (+19 -2) 📝 `src/Android/Accessibility/AccessibilityHelpers.cs` (+2 -0) 📝 `src/Android/Accessibility/AccessibilityService.cs` (+66 -4) 📝 `src/Android/Android.csproj` (+1 -0) 📝 `src/Android/Resources/values/strings.xml` (+3 -0) ➕ `src/Android/Tiles/AutofillTileService.cs` (+95 -0) 📝 `src/App/Resources/AppResources.Designer.cs` (+12 -0) 📝 `src/App/Resources/AppResources.resx` (+6 -0) 📝 `src/Core/Constants.cs` (+1 -0) </details> ### 📄 Description The user can now add a "scan & fill" quick setting tile on Android 7.0+ via the Android's tile edit/config mechanism. It uses accessibility to perform the autofill and can be used in addition to, or in lieu of, the accessibility overlay (by leaving the overlay permission disabled they can safely use the tile only - the missing-overlay-permission toast only appears if the tile isn't enabled). Fun stuff: - You can only collapse the quick settings dropdown by launching an activity or opening a dialog. Once I accepted defeat here I resorted to using a dialog for the "you need to enable accessibility" error, and an activity to trigger the broadcast message to the accessibility service to perform a field search. - Without waiting 250ms after receiving the trigger message, the window parser would routinely only see the system UI which we ignore by default. Can't beat a good nap. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-15 01:40:29 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#15344
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?