github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-05-07 19:39:41 -05:00
Code Issues 1.1k Packages Projects Releases 122 Wiki Activity

[GH-ISSUE #5175] Strange behavior on validateOrigin #14862

New Issue
Closed
opened 2026-04-15 01:01:45 -05:00 by GiteaMirror · 2 comments
GiteaMirror commented 2026-04-15 01:01:45 -05:00
Owner
Copy Link

Originally created by @Nailik on GitHub (May 12, 2025).
Original GitHub issue: https://github.com/bitwarden/android/issues/5175

Steps To Reproduce

validateOrigin is used to validate that the calling app or website is allowed to access specific credentials

  1. Validate Origin checks for "delegate_permission/common.handle_all_urls" but since this is only a password manager i think it should only check for "delegate_permission/common.get_login_creds"
  2. If it's not an website that calls this but the app itself then oritin and target matches (in packageName and also in certificateFingerprint) however currently the google service is called which will return only maxAge without linked = true which results in PasskeyNotSupportedForApp which doesn't really make sense

Expected Result

  • Check only for login_creds allowed
  • If source and target is the same app there is no reason to call google api (i think)

Actual Result

PasskeyNotSupportedForApp error

Screenshots or Videos

No response

Additional Context

No response

Build Version

2c71ab7d27

What server are you connecting to?

EU

Self-host Server Version

Environment Details

No response

Issue Tracking Info

  • I understand that work is tracked outside of Github. A PR will be linked to this issue should one be opened to address it, but Bitwarden doesn't use fields like "assigned", "milestone", or "project" to track progress.
Originally created by @Nailik on GitHub (May 12, 2025). Original GitHub issue: https://github.com/bitwarden/android/issues/5175 ### Steps To Reproduce `validateOrigin` is used to validate that the calling app or website is allowed to access specific credentials 1. Validate Origin checks for "delegate_permission/common.handle_all_urls" but since this is only a password manager i think it should only check for "delegate_permission/common.get_login_creds" 2. If it's not an website that calls this but the app itself then oritin and target matches (in `packageName` and also in `certificateFingerprint`) however currently the google service is called which will return only maxAge without `linked = true` which results in `PasskeyNotSupportedForApp` which doesn't really make sense ### Expected Result - Check only for login_creds allowed - If source and target is the same app there is no reason to call google api (i think) ### Actual Result `PasskeyNotSupportedForApp` error ### Screenshots or Videos _No response_ ### Additional Context _No response_ ### Build Version 2c71ab7d27d7f976766adee7bfd1828d5eda0850 ### What server are you connecting to? EU ### Self-host Server Version - ### Environment Details _No response_ ### Issue Tracking Info - [x] I understand that work is tracked outside of Github. A PR will be linked to this issue should one be opened to address it, but Bitwarden doesn't use fields like "assigned", "milestone", or "project" to track progress.
GiteaMirror added the app:password-managerbug labels 2026-04-15 01:01:45 -05:00
GiteaMirror commented 2026-04-15 01:01:48 -05:00
Author
Owner
Copy Link

@S-Kakar commented on GitHub (May 12, 2025):

Thank you for your report! We've added this to our internal board for review.
ID: PM-21557

<!-- gh-comment-id:2873180084 --> @S-Kakar commented on GitHub (May 12, 2025): Thank you for your report! We've added this to our internal board for review. ID: PM-21557
GiteaMirror commented 2026-04-15 01:01:49 -05:00
Author
Owner
Copy Link

@Nailik commented on GitHub (May 12, 2025):

closed: i directly added my questions to https://github.com/bitwarden/android/pull/5101

<!-- gh-comment-id:2873482404 --> @Nailik commented on GitHub (May 12, 2025): closed: i directly added my questions to https://github.com/bitwarden/android/pull/5101
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label app:password-manager bug
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#14862
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?