github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-03-13 21:54:17 -05:00
Code Issues 144 Packages Projects Releases 116 Wiki Activity

Android/iOS: Accessibility - expand label/name for password generator toggles #1456

New Issue
Closed
opened 2025-11-26 22:49:39 -06:00 by GiteaMirror · 2 comments
GiteaMirror commented 2025-11-26 22:49:39 -06:00
Owner
Copy Link

Originally created by @patrickhlauke on GitHub (May 21, 2022).

Originally assigned to: @andrebispo5 on GitHub.

Steps To Reproduce

  1. Turn on VoiceOver/iOS, Talkback/Android
  2. Go to Password generator screen
  3. Go to the "A-Z", "a-z", "0-9", "!@#$%^&*" toggles

Expected Result

The switches should have a clear announcement that is understandable for assistive technology users.

Actual Result

In Talkback/Android, the options are announced as "a to zed", "a to zed" (no differentiation on upper or lowercase), "zero to nine", "at hash dollar percent caret and asterisk".

In VoiceOver/iOS, the options are announced as "a zed", "a zed", "zero nine", "exclamation point at hash symbol dollar percent caret and star".

Screenshots or Videos

No response

Additional Context

Suggest doing the same change made on the extension https://github.com/bitwarden/clients/pull/2233, the desktop app https://github.com/bitwarden/desktop/pull/1461, and the web vault https://github.com/bitwarden/web/pull/1611 - expanding the accessible names/labels for those switches to Uppercase (A-Z), Lowercase (a-z), Numbers (0-9), Special Characters (!@#$%^&*)

Obviously, this will mean adding strings in the app resources, and getting them translated as well (translations have already been done for the browser, desktop, and web vault, so should be straightforward to just grab them from there).

Operating System

Android, iOS

Operating System Version

No response

Device

No response

Build Version

2.18.0 (4572)

Beta

  • Using a pre-release version of the application.
Originally created by @patrickhlauke on GitHub (May 21, 2022). Originally assigned to: @andrebispo5 on GitHub. ### Steps To Reproduce 1. Turn on VoiceOver/iOS, Talkback/Android 2. Go to Password generator screen 3. Go to the "A-Z", "a-z", "0-9", "!@#$%^&*" toggles ### Expected Result The switches should have a clear announcement that is understandable for assistive technology users. ### Actual Result In Talkback/Android, the options are announced as "a to zed", "a to zed" (no differentiation on upper or lowercase), "zero to nine", "at hash dollar percent caret and asterisk". In VoiceOver/iOS, the options are announced as "a zed", "a zed", "zero nine", "exclamation point at hash symbol dollar percent caret and star". ### Screenshots or Videos _No response_ ### Additional Context Suggest doing the same change made on the extension https://github.com/bitwarden/clients/pull/2233, the desktop app https://github.com/bitwarden/desktop/pull/1461, and the web vault https://github.com/bitwarden/web/pull/1611 - expanding the accessible names/labels for those switches to `Uppercase (A-Z)`, `Lowercase (a-z)`, `Numbers (0-9)`, `Special Characters (!@#$%^&*)` Obviously, this will mean adding strings in the app resources, and getting them translated as well (translations have already been done for the browser, desktop, and web vault, so should be straightforward to just grab them from there). ### Operating System Android, iOS ### Operating System Version _No response_ ### Device _No response_ ### Build Version 2.18.0 (4572) ### Beta - [ ] Using a pre-release version of the application.
GiteaMirror added the bug label 2025-11-26 22:49:39 -06:00
GiteaMirror commented 2025-11-26 22:49:39 -06:00
Author
Owner
Copy Link

@patrickhlauke commented on GitHub (May 21, 2022):

I'm guessing the changes need to be made in https://github.com/bitwarden/mobile/blob/master/src/iOS.Core/Controllers/PasswordGeneratorViewController.cs and https://github.com/bitwarden/mobile/blob/master/src/App/Pages/Generator/GeneratorPage.xaml

@patrickhlauke commented on GitHub (May 21, 2022): I'm guessing the changes need to be made in https://github.com/bitwarden/mobile/blob/master/src/iOS.Core/Controllers/PasswordGeneratorViewController.cs and https://github.com/bitwarden/mobile/blob/master/src/App/Pages/Generator/GeneratorPage.xaml
GiteaMirror commented 2025-11-26 22:49:39 -06:00
Author
Owner
Copy Link

@patrickhlauke commented on GitHub (May 25, 2022):

thanks @andrebispo5

@patrickhlauke commented on GitHub (May 25, 2022): thanks @andrebispo5
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label bug
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#1456
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?