github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-03-21 13:52:07 -05:00
Code Issues 144 Packages Projects Releases 116 Wiki Activity

Improve Accessibility Labeling #134

New Issue
Closed
opened 2025-11-07 08:28:19 -06:00 by GiteaMirror · 6 comments
GiteaMirror commented 2025-11-07 08:28:19 -06:00
Owner
Copy Link

Originally created by @kspearrin on GitHub (Nov 26, 2017).

There are a lot of accessibility labels missing on buttons and inputs that make screen readers more effective.

Originally created by @kspearrin on GitHub (Nov 26, 2017). There are a lot of accessibility labels missing on buttons and inputs that make screen readers more effective.
GiteaMirror commented 2025-11-07 08:28:21 -06:00
Author
Owner
Copy Link

@Flameborn commented on GitHub (Feb 11, 2019):

The two most needed parts that require accessible labels are the tabs on the bottom, as well as the two buttons next to the entries list.

In addition, the app becomes inaccessible after logging in, and the only fix is to restart the application, after which VoiceOver is able to detect the elements on-screen.

@Flameborn commented on GitHub (Feb 11, 2019): The two most needed parts that require accessible labels are the tabs on the bottom, as well as the two buttons next to the entries list. In addition, the app becomes inaccessible after logging in, and the only fix is to restart the application, after which VoiceOver is able to detect the elements on-screen.
GiteaMirror commented 2025-11-07 08:28:21 -06:00
Author
Owner
Copy Link

@steverep commented on GitHub (Apr 5, 2019):

I would add that many actionable items are not given a proper accessible role, such as a button or link. For example, the "Regenerate Password" button on the generator tab is just announced by VoiceOver as normal text and oddly says "empty list" before it.

In context, it's usually clear what is clickable, but this should be fixed for better accessibility as well.

@steverep commented on GitHub (Apr 5, 2019): I would add that many actionable items are not given a proper accessible role, such as a button or link. For example, the "Regenerate Password" button on the generator tab is just announced by VoiceOver as normal text and oddly says "empty list" before it. In context, it's usually clear what is clickable, but this should be fixed for better accessibility as well.
GiteaMirror commented 2025-11-07 08:28:22 -06:00
Author
Owner
Copy Link

@pitermach commented on GitHub (Jul 15, 2019):

Updating this issue for Bitwarden 2.1.0.51 (iOS) not sure about the state of accessibility on Android.

The bottom 3 tabs now have labels, as do the search and add buttons at the top.
However, on the main view/edit item screen, most buttons have lost their labels. Edit, options, save and cancel buttons still have labels, but the controls to copy the username and password, as well as showing/hiding it and checking whether it was exposed are all now unlabeled and just read as "button". Same goes for the buttons next to each entry in the vault that display the overflow menu.

@pitermach commented on GitHub (Jul 15, 2019): Updating this issue for Bitwarden 2.1.0.51 (iOS) not sure about the state of accessibility on Android. The bottom 3 tabs now have labels, as do the search and add buttons at the top. However, on the main view/edit item screen, most buttons have lost their labels. Edit, options, save and cancel buttons still have labels, but the controls to copy the username and password, as well as showing/hiding it and checking whether it was exposed are all now unlabeled and just read as "button". Same goes for the buttons next to each entry in the vault that display the overflow menu.
GiteaMirror commented 2025-11-07 08:28:22 -06:00
Author
Owner
Copy Link

@kspearrin commented on GitHub (Jul 22, 2019):

Thanks @pitermach . For the next version, I have added a11y labels to all the icon text and icon buttons that I could find.

@kspearrin commented on GitHub (Jul 22, 2019): Thanks @pitermach . For the next version, I have added a11y labels to all the icon text and icon buttons that I could find.
GiteaMirror commented 2025-11-07 08:28:22 -06:00
Author
Owner
Copy Link

@pitermach commented on GitHub (Jul 22, 2019):

Hello Kyle,
Awesome, that’s great to hear. Thank you.

From: Kyle Spearrin
Sent: Monday, July 22, 2019 5:57 PM
To: bitwarden/mobile
Cc: pitermach; Mention
Subject: Re: [bitwarden/mobile] Improve Accessibility Labeling (#187)

Thanks @pitermach . For the next version, I have added a11y labels to all the icon text and icon buttons that I could find.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.

@pitermach commented on GitHub (Jul 22, 2019): Hello Kyle, Awesome, that’s great to hear. Thank you. From: Kyle Spearrin Sent: Monday, July 22, 2019 5:57 PM To: bitwarden/mobile Cc: pitermach; Mention Subject: Re: [bitwarden/mobile] Improve Accessibility Labeling (#187) Thanks @pitermach . For the next version, I have added a11y labels to all the icon text and icon buttons that I could find. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.
GiteaMirror commented 2025-11-07 08:28:23 -06:00
Author
Owner
Copy Link

@djsmith85 commented on GitHub (Mar 10, 2022):

Closing this as per Kyle's comment, the a11y labels were added. If someone is still encountering missing accessibility labels, feel free to open a new issue.

@djsmith85 commented on GitHub (Mar 10, 2022): Closing this as per Kyle's comment, the a11y labels were added. If someone is still encountering missing accessibility labels, feel free to open a new issue.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#134
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?