github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-05-07 11:29:37 -05:00
Code Issues 1.1k Packages Projects Releases 122 Wiki Activity

[PR #6721] [PM-34126] feat: Add card scan screen #12961

New Issue
Closed
opened 2026-04-11 03:54:48 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-11 03:54:48 -05:00
Owner
Copy Link

Original Pull Request: https://github.com/bitwarden/android/pull/6721

State: closed
Merged: Yes

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-34126

📔 Objective

Add the card scan screen with camera integration for credit card scanning:

  • CardScanManager: Shared result channel between scanner and consumer, located in ui module (cardscanner/manager/)
  • CardScanResult: Sealed class wrapping CardScanData for success/error states
  • CardScanViewModel: State management with duplicate-scan guarding and DeferredBackgroundEvent
  • CardScanScreen: Composable with camera preview, overlay, and close button
  • CardScanNavigation: Type-safe route and navigation helper
  • CardScanner feature flag: Gated behind card-scanner-mobile FlagKey
  • BitwardenComposeTest: Added cardTextAnalyzer parameter to setContent

Includes ViewModel, Screen, and Manager tests.

📸 Screenshots

**Original Pull Request:** https://github.com/bitwarden/android/pull/6721 **State:** closed **Merged:** Yes --- ## 🎟️ Tracking https://bitwarden.atlassian.net/browse/PM-34126 ## 📔 Objective Add the card scan screen with camera integration for credit card scanning: - **CardScanManager**: Shared result channel between scanner and consumer, located in `ui` module (`cardscanner/manager/`) - **CardScanResult**: Sealed class wrapping `CardScanData` for success/error states - **CardScanViewModel**: State management with duplicate-scan guarding and `DeferredBackgroundEvent` - **CardScanScreen**: Composable with camera preview, overlay, and close button - **CardScanNavigation**: Type-safe route and navigation helper - **CardScanner feature flag**: Gated behind `card-scanner-mobile` FlagKey - **BitwardenComposeTest**: Added `cardTextAnalyzer` parameter to `setContent` Includes ViewModel, Screen, and Manager tests. ## 📸 Screenshots <img width="365" src="https://github.com/user-attachments/assets/0925094f-41b5-4581-9121-9e31950ae73f" />
GiteaMirror added the pull-request label 2026-04-11 03:54:48 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#12961
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?