github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-05-06 15:58:22 -05:00
Code Issues 1.1k Packages Projects Releases 122 Wiki Activity

[PR #6717] feat: Add collection management to Android #12957

New Issue
Open
opened 2026-04-11 03:54:40 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-11 03:54:40 -05:00
Owner
Copy Link

Original Pull Request: https://github.com/bitwarden/android/pull/6717

State: open
Merged: No

Summary

  • Add full CRUD support for managing collections on Android via Settings > Vault > Collections
  • Collections are organization-scoped vault items available on paid plans
  • Network layer: CollectionsApi, CollectionService with create/update/delete/get endpoints
  • Data layer: CollectionManager with encrypt → API → disk → decrypt flow
  • Permission model: expanded with collection-specific permission fields and role-based checks matching web client logic
  • UI: CollectionsScreen (list with org subtitles, permission-gated FAB), CollectionAddEditScreen (name field, save, delete)
  • Creating user automatically gets manage access on new collections
  • Update requests preserve existing group/user access permissions

Test plan

  • Log in with account that has a paid organization
  • Navigate to Settings > Vault > Collections
  • Verify FAB is visible for Owner/Admin roles
  • Create a new collection and verify snackbar confirmation
  • Move an item to the new collection (verify no permission error)
  • Edit a collection name and verify save works
  • Delete a collection and verify confirmation dialog and removal
  • Verify FAB is hidden for users without create permission
  • Verify / character is rejected in collection name

Notes

  • SDK encryptCollection requires a local SDK build from sdk-internal with collection encryption support (not yet in published SDK)
  • Commit 27eab557 adapts to local SDK API changes for development; will need adjustment when official SDK is bumped
  • Requirements doc at docs/COLLECTIONS_REQUIREMENTS.md
  • Implementation plan at .claude/outputs/plans/COLLECTION-MANAGEMENT-PLAN.md
**Original Pull Request:** https://github.com/bitwarden/android/pull/6717 **State:** open **Merged:** No --- ## Summary - Add full CRUD support for managing collections on Android via Settings > Vault > Collections - Collections are organization-scoped vault items available on paid plans - Network layer: CollectionsApi, CollectionService with create/update/delete/get endpoints - Data layer: CollectionManager with encrypt → API → disk → decrypt flow - Permission model: expanded with collection-specific permission fields and role-based checks matching web client logic - UI: CollectionsScreen (list with org subtitles, permission-gated FAB), CollectionAddEditScreen (name field, save, delete) - Creating user automatically gets manage access on new collections - Update requests preserve existing group/user access permissions ## Test plan - [ ] Log in with account that has a paid organization - [ ] Navigate to Settings > Vault > Collections - [ ] Verify FAB is visible for Owner/Admin roles - [ ] Create a new collection and verify snackbar confirmation - [ ] Move an item to the new collection (verify no permission error) - [ ] Edit a collection name and verify save works - [ ] Delete a collection and verify confirmation dialog and removal - [ ] Verify FAB is hidden for users without create permission - [ ] Verify `/` character is rejected in collection name ## Notes - SDK `encryptCollection` requires a local SDK build from `sdk-internal` with collection encryption support (not yet in published SDK) - Commit `27eab557` adapts to local SDK API changes for development; will need adjustment when official SDK is bumped - Requirements doc at `docs/COLLECTIONS_REQUIREMENTS.md` - Implementation plan at `.claude/outputs/plans/COLLECTION-MANAGEMENT-PLAN.md`
GiteaMirror added the pull-request label 2026-04-11 03:54:40 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#12957
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?