github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-08-16 03:01:21 -05:00
Code Issues 2.4k Packages Projects Releases 129 Wiki Activity

[PR #6678] [PM-33365] feat: Add GmsManager to gate CXP features on GMS Core version #12921

New Issue
Closed
opened 2026-04-11 03:53:38 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-11 03:53:38 -05:00
Owner
Copy Link
Copy Source

Original Pull Request: https://github.com/bitwarden/android/pull/6678

State: closed
Merged: Yes

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-33365

📔 Objective

Add a GmsManager to check the installed Google Mobile Services (GMS) Core version and gate Credential Exchange Protocol (CXP) features behind a minimum version requirement (261031035).

Changes:

  • New GmsManager interface with isVersionAtLeast(version: Int) method
  • Standard flavor implementation using GoogleApiAvailabilityLight to query the installed GMS Core APK version
  • F-Droid flavor implementation that always returns false (no GMS available)
  • Hilt module binding in PlatformManagerModule
  • VaultSettingsViewModel — gates import items chevron visibility and CXP import navigation on GMS version
  • VaultViewModel — gates CXP export registry registration on GMS version
  • Unit tests for GmsManagerImpl, VaultSettingsViewModel, and VaultViewModel covering the new GMS version checks
**Original Pull Request:** https://github.com/bitwarden/android/pull/6678 **State:** closed **Merged:** Yes --- ## 🎟️ Tracking https://bitwarden.atlassian.net/browse/PM-33365 ## 📔 Objective Add a `GmsManager` to check the installed Google Mobile Services (GMS) Core version and gate Credential Exchange Protocol (CXP) features behind a minimum version requirement (`261031035`). **Changes:** - New `GmsManager` interface with `isVersionAtLeast(version: Int)` method - Standard flavor implementation using `GoogleApiAvailabilityLight` to query the installed GMS Core APK version - F-Droid flavor implementation that always returns `false` (no GMS available) - Hilt module binding in `PlatformManagerModule` - `VaultSettingsViewModel` — gates import items chevron visibility and CXP import navigation on GMS version - `VaultViewModel` — gates CXP export registry registration on GMS version - Unit tests for `GmsManagerImpl`, `VaultSettingsViewModel`, and `VaultViewModel` covering the new GMS version checks
GiteaMirror added the pull-request label 2026-04-11 03:53:38 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No labels pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
GiteaMirror ninjasurge (Kaehlen Rog)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#12921