github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-08-23 13:07:48 -05:00
Code Issues 2.4k Packages Projects Releases 129 Wiki Activity

[PR #6657] [PM-33507] feat: Add premium upgrade banner dismissal persistence #12902

New Issue
Closed
opened 2026-04-11 03:53:09 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-11 03:53:09 -05:00
Owner
Copy Link
Copy Source

Original Pull Request: https://github.com/bitwarden/android/pull/6657

State: closed
Merged: Yes

🎟️ Tracking

PM-33507
Parent: PM-33137

📔 Objective

Add per-user banner dismissed state to SettingsDiskSource and SettingsRepository, following the existing archive action card pattern.

  • Add get/storePremiumUpgradeBannerDismissed + flow to SettingsDiskSource
  • Implement in SettingsDiskSourceImpl with per-userId SharedPreferences storage
  • Expose dismissPremiumUpgradeBanner() and getPremiumUpgradeBannerDismissedFlow() via SettingsRepository
  • Dismissed state cleared on logout
**Original Pull Request:** https://github.com/bitwarden/android/pull/6657 **State:** closed **Merged:** Yes --- ## 🎟️ Tracking [PM-33507](https://bitwarden.atlassian.net/browse/PM-33507) Parent: [PM-33137](https://bitwarden.atlassian.net/browse/PM-33137) ## 📔 Objective Add per-user banner dismissed state to `SettingsDiskSource` and `SettingsRepository`, following the existing archive action card pattern. - Add `get/storePremiumUpgradeBannerDismissed` + flow to `SettingsDiskSource` - Implement in `SettingsDiskSourceImpl` with per-userId SharedPreferences storage - Expose `dismissPremiumUpgradeBanner()` and `getPremiumUpgradeBannerDismissedFlow()` via `SettingsRepository` - Dismissed state cleared on logout [PM-33507]: https://bitwarden.atlassian.net/browse/PM-33507?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ [PM-33137]: https://bitwarden.atlassian.net/browse/PM-33137?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ
GiteaMirror added the pull-request label 2026-04-11 03:53:09 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No labels pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
GiteaMirror ninjasurge (Kaehlen Rog)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#12902