github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-08-16 03:01:21 -05:00
Code Issues 2.4k Packages Projects Releases 129 Wiki Activity

[PR #6652] [PM-33560] debt: Wire SendManager and Send ViewModel error handlers #12897

New Issue
Closed
opened 2026-04-11 03:53:02 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-11 03:53:02 -05:00
Owner
Copy Link
Copy Source

Original Pull Request: https://github.com/bitwarden/android/pull/6652

State: closed
Merged: Yes

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-33560

📔 Objective

Wire userFriendlyMessage through SendManager fold(onFailure) for deleteSend and update all Send-related ViewModel error handlers to prefer errorMessage over generic defaults.

This is part of the PM-33394 series to surface CookieRedirectException user-friendly messages through result types to ViewModels. The foundation (userFriendlyMessage extension and errorMessage on result types) was merged in #6642.

Changes:

  • Wire userFriendlyMessage in SendManager for deleteSend
  • Update SendViewModel, AddEditSendViewModel, and ViewSendViewModel error handlers
  • Add SendManager and ViewModel tests for CookieRedirectException error message propagation
**Original Pull Request:** https://github.com/bitwarden/android/pull/6652 **State:** closed **Merged:** Yes --- ## 🎟️ Tracking https://bitwarden.atlassian.net/browse/PM-33560 ## 📔 Objective Wire `userFriendlyMessage` through SendManager `fold(onFailure)` for `deleteSend` and update all Send-related ViewModel error handlers to prefer `errorMessage` over generic defaults. This is part of the PM-33394 series to surface `CookieRedirectException` user-friendly messages through result types to ViewModels. The foundation (`userFriendlyMessage` extension and `errorMessage` on result types) was merged in #6642. **Changes:** - Wire `userFriendlyMessage` in SendManager for deleteSend - Update SendViewModel, AddEditSendViewModel, and ViewSendViewModel error handlers - Add SendManager and ViewModel tests for CookieRedirectException error message propagation
GiteaMirror added the pull-request label 2026-04-11 03:53:03 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No labels pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
GiteaMirror ninjasurge (Kaehlen Rog)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#12897