github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-06-12 22:51:28 -05:00
Code Issues 2.3k Packages Projects Releases 128 Wiki Activity

[PR #6644] 🍒[PM-33394] debt: Add userFriendlyMessage extension and errorMessage to result types #12889

New Issue
Closed
opened 2026-04-11 03:52:55 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-11 03:52:55 -05:00
Owner
Copy Link

Original Pull Request: https://github.com/bitwarden/android/pull/6644

State: closed
Merged: Yes

🎟️ Tracking

PM-33394
Cherry-picked from #6642

📔 Objective

Adds infrastructure for propagating user-friendly error messages from exceptions through vault operation result types.

  • Introduces Throwable.userFriendlyMessage extension that extracts display-safe messages from allow-listed exception types (currently CookieRedirectException)
  • Adds optional errorMessage parameter to Error variants of 9 vault result sealed classes, enabling ViewModels to display specific error text when available
  • Includes unit tests for the new extension property
**Original Pull Request:** https://github.com/bitwarden/android/pull/6644 **State:** closed **Merged:** Yes --- ## 🎟️ Tracking PM-33394 Cherry-picked from #6642 ## 📔 Objective Adds infrastructure for propagating user-friendly error messages from exceptions through vault operation result types. - Introduces `Throwable.userFriendlyMessage` extension that extracts display-safe messages from allow-listed exception types (currently `CookieRedirectException`) - Adds optional `errorMessage` parameter to `Error` variants of 9 vault result sealed classes, enabling ViewModels to display specific error text when available - Includes unit tests for the new extension property
GiteaMirror added the pull-request label 2026-04-11 03:52:55 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#12889
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?