github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-05-08 04:16:40 -05:00
Code Issues 1.1k Packages Projects Releases 122 Wiki Activity

[PR #6589] [PM-32714] Add cookie domain-suffix resolution and fix cloud config path exclusion #12843

New Issue
Closed
opened 2026-04-11 03:52:13 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-11 03:52:13 -05:00
Owner
Copy Link

Original Pull Request: https://github.com/bitwarden/android/pull/6589

State: closed
Merged: Yes

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-32714

📔 Objective

Cookies stored under a parent cookieDomain (e.g., "bitwarden.com") were not found when requesting via subdomains (e.g., "api.bitwarden.com"). Additionally, cloud servers use "/config" instead of "/api/config", causing the config endpoint to hit cookie handling and read stale state.

This adds a resolveHostname helper for domain-suffix fallback, updates storeCookies to key on cookieDomain, fixes excluded path matching to cover both cloud and self-hosted config paths, and adds debug logging along the cookie management path.

**Original Pull Request:** https://github.com/bitwarden/android/pull/6589 **State:** closed **Merged:** Yes --- ## 🎟️ Tracking https://bitwarden.atlassian.net/browse/PM-32714 ## 📔 Objective Cookies stored under a parent cookieDomain (e.g., "bitwarden.com") were not found when requesting via subdomains (e.g., "api.bitwarden.com"). Additionally, cloud servers use "/config" instead of "/api/config", causing the config endpoint to hit cookie handling and read stale state. This adds a `resolveHostname` helper for domain-suffix fallback, updates `storeCookies` to key on `cookieDomain`, fixes excluded path matching to cover both cloud and self-hosted config paths, and adds debug logging along the cookie management path.
GiteaMirror added the pull-request label 2026-04-11 03:52:13 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#12843
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?