github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-05-07 19:39:41 -05:00
Code Issues 1.1k Packages Projects Releases 122 Wiki Activity

[PR #6564] [PM-32566] Refactor cookie acquisition ViewModel and simplify tests #12822

New Issue
Closed
opened 2026-04-11 03:51:51 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-11 03:51:51 -05:00
Owner
Copy Link

Original Pull Request: https://github.com/bitwarden/android/pull/6564

State: closed
Merged: Yes

🎟️ Tracking

PM-32566

📔 Objective

Refactor the cookie acquisition flow to simplify hostname derivation and improve reliability:

  • Add hostname to CookieAcquisitionState: Snapshot the hostname via requireNotNull at ViewModel init time, since MainViewModel guarantees the request is non-null when navigating to this screen.
  • Add filterNotNull to MainViewModel: Prevent the cookie acquisition screen from being navigated to on the initial null emission of the StateFlow.
  • Move AuthTabData construction into ViewModel: Follow the established pattern from EnterpriseSignOnViewModel where the event carries all data needed by the screen.
  • Simplify CookieUtilsTest: Remove duplicate cookie-parsing tests from the Intent extension section (covered by Uri extension tests), and replace lateinit/@BeforeEach with inline property initialization.
**Original Pull Request:** https://github.com/bitwarden/android/pull/6564 **State:** closed **Merged:** Yes --- ## 🎟️ Tracking PM-32566 ## 📔 Objective Refactor the cookie acquisition flow to simplify hostname derivation and improve reliability: - Add hostname to CookieAcquisitionState: Snapshot the hostname via requireNotNull at ViewModel init time, since MainViewModel guarantees the request is non-null when navigating to this screen. - Add filterNotNull to MainViewModel: Prevent the cookie acquisition screen from being navigated to on the initial null emission of the StateFlow. - Move AuthTabData construction into ViewModel: Follow the established pattern from EnterpriseSignOnViewModel where the event carries all data needed by the screen. - Simplify CookieUtilsTest: Remove duplicate cookie-parsing tests from the Intent extension section (covered by Uri extension tests), and replace `lateinit/@BeforeEach` with inline property initialization.
GiteaMirror added the pull-request label 2026-04-11 03:51:51 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#12822
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?