github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-05-06 07:48:22 -05:00
Code Issues 1.1k Packages Projects Releases 122 Wiki Activity

[PR #6537] [PM-32251] Decouple SDK token repository from network module #12798

New Issue
Closed
opened 2026-04-11 03:51:25 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-11 03:51:25 -05:00
Owner
Copy Link

Original Pull Request: https://github.com/bitwarden/android/pull/6537

State: closed
Merged: Yes

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-32251

📔 Objective

Decouple the SDK bridge layer from the :network module by replacing BitwardenServiceClient.tokenProvider with direct AuthDiskSource access in SdkTokenRepository.

Previously, SdkRepositoryFactoryImpl depended on BitwardenServiceClient solely to extract its tokenProvider. This created an unnecessary coupling between the SDK bridge and the entire :network module for a single method call. Since access tokens ultimately come from AuthDiskSource (encrypted disk storage), we can bypass :network entirely.

Changes:

  • SdkTokenRepository now takes AuthDiskSource directly and reads getAccountTokens(userId)?.accessToken
  • SdkRepositoryFactoryImpl constructor parameter changed from BitwardenServiceClient to AuthDiskSource
  • PlatformManagerModule Hilt wiring updated accordingly
  • Tests updated to mock AuthDiskSource instead of TokenProvider/BitwardenServiceClient
**Original Pull Request:** https://github.com/bitwarden/android/pull/6537 **State:** closed **Merged:** Yes --- ## 🎟️ Tracking https://bitwarden.atlassian.net/browse/PM-32251 ## 📔 Objective Decouple the SDK bridge layer from the `:network` module by replacing `BitwardenServiceClient.tokenProvider` with direct `AuthDiskSource` access in `SdkTokenRepository`. Previously, `SdkRepositoryFactoryImpl` depended on `BitwardenServiceClient` solely to extract its `tokenProvider`. This created an unnecessary coupling between the SDK bridge and the entire `:network` module for a single method call. Since access tokens ultimately come from `AuthDiskSource` (encrypted disk storage), we can bypass `:network` entirely. **Changes:** - `SdkTokenRepository` now takes `AuthDiskSource` directly and reads `getAccountTokens(userId)?.accessToken` - `SdkRepositoryFactoryImpl` constructor parameter changed from `BitwardenServiceClient` to `AuthDiskSource` - `PlatformManagerModule` Hilt wiring updated accordingly - Tests updated to mock `AuthDiskSource` instead of `TokenProvider`/`BitwardenServiceClient`
GiteaMirror added the pull-request label 2026-04-11 03:51:26 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#12798
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?