github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-05-06 07:48:22 -05:00
Code Issues 1.1k Packages Projects Releases 122 Wiki Activity

[PR #6502] [PM-31980] Fix passkeys on some browsers by fixing JSON parsing #12769

New Issue
Closed
opened 2026-04-11 03:50:58 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-11 03:50:58 -05:00
Owner
Copy Link

Original Pull Request: https://github.com/bitwarden/android/pull/6502

State: closed
Merged: Yes

🎟️ Tracking

Closes #6463
Closes PM-31597

📔 Objective

Fix JSON parsing by removing comma, which caused passkeys to stop working on some browsers.

Regression introduced with #6299 (PM-30260).

Sorry if I shortcut some processes, but the fix is pretty short.

Tested on Fennec. If you close my PR to develop a long-term solution (adding some tests), I don't mind.

**Original Pull Request:** https://github.com/bitwarden/android/pull/6502 **State:** closed **Merged:** Yes --- ## 🎟️ Tracking Closes #6463 Closes PM-31597 ## 📔 Objective Fix JSON parsing by removing comma, which caused passkeys to stop working on some browsers. Regression introduced with #6299 (PM-30260). Sorry if I shortcut some processes, but the fix is pretty short. Tested on Fennec. If you close my PR to develop a long-term solution (adding some tests), I don't mind.
GiteaMirror added the pull-request label 2026-04-11 03:50:58 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#12769
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?