github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-06-10 08:36:09 -05:00
Code Issues 2.2k Packages Projects Releases 127 Wiki Activity

[PR #6473] PM-31656, PM-31658, PM-31659: Address Archive feature bugs #12750

New Issue
Closed
opened 2026-04-11 03:50:38 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-11 03:50:38 -05:00
Owner
Copy Link

Original Pull Request: https://github.com/bitwarden/android/pull/6473

State: closed
Merged: Yes

🎟️ Tracking

PM-31655
PM-31656
PM-31658
PM-31659
PM-31663

📔 Objective

This PR address multiple small bugs associated with the archive feature.

  • The Archive row should display a premium required dialog if the user does not have premium but does have ciphers.
  • The introducing archive action card should be dismissed if the user clicks the X, primary action button or archives a cipher.
  • We no long display the premium required content on the Archive list item when the user has archived items without a premium account.
  • Archived ciphers should not be displayed in the Authenticator when the Sync feature is enabled.

📸 Screenshots

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes
**Original Pull Request:** https://github.com/bitwarden/android/pull/6473 **State:** closed **Merged:** Yes --- ## 🎟️ Tracking [PM-31655](https://bitwarden.atlassian.net/browse/PM-31655) [PM-31656](https://bitwarden.atlassian.net/browse/PM-31656) [PM-31658](https://bitwarden.atlassian.net/browse/PM-31658) [PM-31659](https://bitwarden.atlassian.net/browse/PM-31659) [PM-31663](https://bitwarden.atlassian.net/browse/PM-31663) ## 📔 Objective This PR address multiple small bugs associated with the archive feature. * The Archive row should display a premium required dialog if the user does not have premium but does have ciphers. * The introducing archive action card should be dismissed if the user clicks the `X`, primary action button or archives a cipher. * We no long display the premium required content on the Archive list item when the user has archived items without a premium account. * Archived ciphers should not be displayed in the Authenticator when the Sync feature is enabled. ## 📸 Screenshots ## ⏰ Reminders before review - Contributor guidelines followed - All formatters and local linters executed and passed - Written new unit and / or integration tests where applicable - Protected functional changes with optionality (feature flags) - Used internationalization (i18n) for all UI strings - CI builds passed - Communicated to DevOps any deployment requirements - Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team ## 🦮 Reviewer guidelines <!-- Suggested interactions but feel free to use (or not) as you desire! --> - 👍 (`:+1:`) or similar for great changes - 📝 (`:memo:`) or ℹ️ (`:information_source:`) for notes or general info - ❓ (`:question:`) for questions - 🤔 (`:thinking:`) or 💭 (`:thought_balloon:`) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion - 🎨 (`:art:`) for suggestions / improvements - ❌ (`:x:`) or ⚠️ (`:warning:`) for more significant problems or concerns needing attention - 🌱 (`:seedling:`) or ♻️ (`:recycle:`) for future improvements or indications of technical debt - ⛏ (`:pick:`) for minor or nitpick changes [PM-31655]: https://bitwarden.atlassian.net/browse/PM-31655?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ [PM-31656]: https://bitwarden.atlassian.net/browse/PM-31656?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ [PM-31658]: https://bitwarden.atlassian.net/browse/PM-31658?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ [PM-31659]: https://bitwarden.atlassian.net/browse/PM-31659?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ [PM-31663]: https://bitwarden.atlassian.net/browse/PM-31663?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ
GiteaMirror added the pull-request label 2026-04-11 03:50:38 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#12750
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?