[PR #6400] [PM-14880] ci: Address automated PR labeling workflow feedback #12695

Closed
opened 2026-04-11 03:49:25 -05:00 by GiteaMirror · 0 comments
Owner

Original Pull Request: https://github.com/bitwarden/android/pull/6400

State: closed
Merged: Yes


🎟️ Tracking

PM-14880

📔 Objective

Address automated PR labeling workflow feedback to better handle existing labels and bot detection:

  1. In replace mode, preserve existing labels that aren't app: or t: - ai-review should now be preserved.
  2. Enhance manual label process by not adding a generic catch-all label
  3. Improve bot detection, should detect all bots and apps - app/ prefix is used when workflow is manually triggered (workflow_dispatch).
  4. Improve workflow name / run-name, making it easier to identify runs

Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes
**Original Pull Request:** https://github.com/bitwarden/android/pull/6400 **State:** closed **Merged:** Yes --- ## 🎟️ Tracking PM-14880 ## 📔 Objective Address automated PR labeling workflow feedback to better handle existing labels and bot detection: 1. In `replace` mode, preserve existing labels that aren't `app:` or `t:` - `ai-review` should now be preserved. 1. Enhance manual label process by not adding a generic catch-all label 1. Improve bot detection, should detect all bots and apps - `app/` prefix is used when workflow is manually triggered (`workflow_dispatch`). 1. Improve workflow name / run-name, making it easier to identify runs ## ⏰ Reminders before review - Contributor guidelines followed - All formatters and local linters executed and passed - Written new unit and / or integration tests where applicable - Protected functional changes with optionality (feature flags) - Used internationalization (i18n) for all UI strings - CI builds passed - Communicated to DevOps any deployment requirements - Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team ## 🦮 Reviewer guidelines <!-- Suggested interactions but feel free to use (or not) as you desire! --> - 👍 (`:+1:`) or similar for great changes - 📝 (`:memo:`) or ℹ️ (`:information_source:`) for notes or general info - ❓ (`:question:`) for questions - 🤔 (`:thinking:`) or 💭 (`:thought_balloon:`) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion - 🎨 (`:art:`) for suggestions / improvements - ❌ (`:x:`) or ⚠️ (`:warning:`) for more significant problems or concerns needing attention - 🌱 (`:seedling:`) or ♻️ (`:recycle:`) for future improvements or indications of technical debt - ⛏ (`:pick:`) for minor or nitpick changes
GiteaMirror added the pull-request label 2026-04-11 03:49:25 -05:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#12695