github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-08-24 14:28:58 -05:00
Code Issues 2.4k Packages Projects Releases 129 Wiki Activity

[PR #6365] [PM-30849] Simplify code-review command to use reviewing-changes skill #12666

New Issue
Closed
opened 2026-04-11 03:48:53 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-11 03:48:53 -05:00
Owner
Copy Link
Copy Source

Original Pull Request: https://github.com/bitwarden/android/pull/6365

State: closed
Merged: No

🎟️ Tracking

PM-30849

📔 Objective

Note

Additional prep for DevClarity training. Builds upon #6364.

Simplify the code-review command by delegating the core logic to the new reviewing-changes skill.

The previous verbose template, which included detailed instructions and a complex output format for manual reviews, has been removed. The new implementation directly invokes the reviewing-changes skill with the pull request URL.

Specific changes include:

  • Replaced the extensive review template in .claude/commands/code-review.md with a simpler command definition.
  • The command now accepts a PR URL as its primary argument.
  • It is explicitly defined to use the reviewing-changes skill for the review process.
  • Output requirements are now specified to be written to pr-review-summary.md and pr-review-inline-comments.md.

📸 Screenshots

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes
**Original Pull Request:** https://github.com/bitwarden/android/pull/6365 **State:** closed **Merged:** No --- ## 🎟️ Tracking PM-30849 ## 📔 Objective > [!NOTE] > Additional prep for DevClarity training. Builds upon #6364. Simplify the `code-review` command by delegating the core logic to the new `reviewing-changes` skill. The previous verbose template, which included detailed instructions and a complex output format for manual reviews, has been removed. The new implementation directly invokes the `reviewing-changes` skill with the pull request URL. Specific changes include: - Replaced the extensive review template in `.claude/commands/code-review.md` with a simpler command definition. - The command now accepts a PR URL as its primary argument. - It is explicitly defined to use the `reviewing-changes` skill for the review process. - Output requirements are now specified to be written to `pr-review-summary.md` and `pr-review-inline-comments.md`. ## 📸 Screenshots <!-- Required for any UI changes; delete if not applicable. Use fixed width images for better display. --> ## ⏰ Reminders before review - Contributor guidelines followed - All formatters and local linters executed and passed - Written new unit and / or integration tests where applicable - Protected functional changes with optionality (feature flags) - Used internationalization (i18n) for all UI strings - CI builds passed - Communicated to DevOps any deployment requirements - Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team ## 🦮 Reviewer guidelines <!-- Suggested interactions but feel free to use (or not) as you desire! --> - 👍 (`:+1:`) or similar for great changes - 📝 (`:memo:`) or ℹ️ (`:information_source:`) for notes or general info - ❓ (`:question:`) for questions - 🤔 (`:thinking:`) or 💭 (`:thought_balloon:`) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion - 🎨 (`:art:`) for suggestions / improvements - ❌ (`:x:`) or ⚠️ (`:warning:`) for more significant problems or concerns needing attention - 🌱 (`:seedling:`) or ♻️ (`:recycle:`) for future improvements or indications of technical debt - ⛏ (`:pick:`) for minor or nitpick changes
GiteaMirror added the pull-request label 2026-04-11 03:48:53 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No labels pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
GiteaMirror ninjasurge (Kaehlen Rog)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#12666