github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-05-07 19:39:41 -05:00
Code Issues 1.1k Packages Projects Releases 122 Wiki Activity

[PR #6305] [MERGED] [PM-14880] Add pull-request trigger to PR Labeling workflow and address test findings #12617

New Issue
Closed
opened 2026-04-11 03:47:58 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-11 03:47:58 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/6305
Author: @vvolkgang
Created: 12/29/2025
Status: ✅ Merged
Merged: 12/30/2025
Merged by: @vvolkgang

Base: main ← Head: vvolkgang/improve-labels

📝 Commits (5)

  • bf0560d Release categories config - Add catch-all under Maintenance
  • e7460df Improve label-pr.py logs
  • c00c047 Add push trigger to workflow and consolidate PR Number env var
  • ce7a583 Re-add emojis to logs
  • 81e96b4 Fix fido2_privileged lists matching

📊 Changes

4 files changed (+13 additions, -9 deletions)

View changed files

📝 .github/label-pr.json (+2 -2)
📝 .github/release.yml (+1 -0)
📝 .github/scripts/label-pr.py (+5 -5)
📝 .github/workflows/sdlc-label-pr.yml (+5 -2)

📄 Description

🎟️ Tracking

PM-14880

📔 Objective

Adds pull-request trigger to sdlc-label-pr.yml and addresses the following bits found while testing:

  1. Consolidate PR Number env var in sdlc-label-pr.yml
  2. Logging - Reduced copy and replaced GitHub summary warnings with notices for informative logs and removes
  3. Add catch-all category to release.yml - handles the transition period when most PRs won't have accurate labels and if we later decide to remove adding t:misc as a fallback in label-pr.py
  4. Fixes the labeling of PRs changing FIDO2 Privileged lists, introduced in https://github.com/bitwarden/android/pull/6304

Test Runs:

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/6305 **Author:** [@vvolkgang](https://github.com/vvolkgang) **Created:** 12/29/2025 **Status:** ✅ Merged **Merged:** 12/30/2025 **Merged by:** [@vvolkgang](https://github.com/vvolkgang) **Base:** `main` ← **Head:** `vvolkgang/improve-labels` --- ### 📝 Commits (5) - [`bf0560d`](https://github.com/bitwarden/android/commit/bf0560d2e35752f439448bc8d77102d7845ceb49) Release categories config - Add catch-all under Maintenance - [`e7460df`](https://github.com/bitwarden/android/commit/e7460df623bf894761d0541c6b7e0a9031859316) Improve label-pr.py logs - [`c00c047`](https://github.com/bitwarden/android/commit/c00c047c676ce6e4cc1dad40c8b95ed3f5bc22eb) Add push trigger to workflow and consolidate PR Number env var - [`ce7a583`](https://github.com/bitwarden/android/commit/ce7a583a592e92718a1ccd04277b2044191ad5b4) Re-add emojis to logs - [`81e96b4`](https://github.com/bitwarden/android/commit/81e96b4495edda0c3cc6a47017f55266aeab7c71) Fix fido2_privileged lists matching ### 📊 Changes **4 files changed** (+13 additions, -9 deletions) <details> <summary>View changed files</summary> 📝 `.github/label-pr.json` (+2 -2) 📝 `.github/release.yml` (+1 -0) 📝 `.github/scripts/label-pr.py` (+5 -5) 📝 `.github/workflows/sdlc-label-pr.yml` (+5 -2) </details> ### 📄 Description ## 🎟️ Tracking PM-14880 ## 📔 Objective Adds pull-request trigger to sdlc-label-pr.yml and addresses the following bits found while testing: 1. Consolidate PR Number env var in sdlc-label-pr.yml 1. Logging - Reduced copy and replaced GitHub summary warnings with notices for informative logs and removes 1. Add catch-all category to `release.yml` - handles the transition period when most PRs won't have accurate labels and if we later decide to remove adding `t:misc` as a fallback in `label-pr.py` 1. Fixes the labeling of PRs changing FIDO2 Privileged lists, introduced in https://github.com/bitwarden/android/pull/6304 Test Runs: * Labeling this PR - https://github.com/bitwarden/android/actions/runs/20583803607 * FIDO2 Privileged list test - https://github.com/bitwarden/android/actions/runs/20583787682 ## ⏰ Reminders before review - Contributor guidelines followed - All formatters and local linters executed and passed - Written new unit and / or integration tests where applicable - Protected functional changes with optionality (feature flags) - Used internationalization (i18n) for all UI strings - CI builds passed - Communicated to DevOps any deployment requirements - Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team ## 🦮 Reviewer guidelines <!-- Suggested interactions but feel free to use (or not) as you desire! --> - 👍 (`:+1:`) or similar for great changes - 📝 (`:memo:`) or ℹ️ (`:information_source:`) for notes or general info - ❓ (`:question:`) for questions - 🤔 (`:thinking:`) or 💭 (`:thought_balloon:`) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion - 🎨 (`:art:`) for suggestions / improvements - ❌ (`:x:`) or ⚠️ (`:warning:`) for more significant problems or concerns needing attention - 🌱 (`:seedling:`) or ♻️ (`:recycle:`) for future improvements or indications of technical debt - ⛏ (`:pick:`) for minor or nitpick changes --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-11 03:47:58 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#12617
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?