[PR #7048] [PM-38808] Support optional encrypted Cipher.name #125631

Open
opened 2026-06-12 05:23:58 -05:00 by GiteaMirror · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/7048
Author: @shane-melton
Created: 6/9/2026
Status: 🔄 Open

Base: main ← Head: PM-38808/support-optional-cipher-name


📝 Commits (1)

  • 9f24711 [PM-38808] Support optional encrypted Cipher.name

📊 Changes

1 file changed (+1 additions, -1 deletions)

View changed files

📝 app/src/main/kotlin/com/x8bit/bitwarden/data/vault/repository/util/VaultSdkCipherExtensions.kt (+1 -1)

📄 Description

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-38808

📔 Objective

The SDK is making the encrypted Cipher.name field optional (String → String?) as part of the blob encryption migration (sdk-internal#1122) — blob-encrypted ciphers carry the name inside the sealed data blob rather than as a top-level field.

Cipher.toFailureCipherListView() builds a CipherListView (whose name is non-null) directly from the encrypted Cipher, so the now-nullable name no longer compiles. This falls back to an empty string when the name is absent.

The decrypted CipherView / CipherListView name fields are unchanged, so all UI and sorting is unaffected.

Pairs with the SDK version bump.


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/7048 **Author:** [@shane-melton](https://github.com/shane-melton) **Created:** 6/9/2026 **Status:** 🔄 Open **Base:** `main` ← **Head:** `PM-38808/support-optional-cipher-name` --- ### 📝 Commits (1) - [`9f24711`](https://github.com/bitwarden/android/commit/9f24711ac78e1a529054d888db6733e265933c16) [PM-38808] Support optional encrypted Cipher.name ### 📊 Changes **1 file changed** (+1 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `app/src/main/kotlin/com/x8bit/bitwarden/data/vault/repository/util/VaultSdkCipherExtensions.kt` (+1 -1) </details> ### 📄 Description ## 🎟️ Tracking https://bitwarden.atlassian.net/browse/PM-38808 ## 📔 Objective The SDK is making the encrypted `Cipher.name` field optional (`String` → `String?`) as part of the blob encryption migration ([sdk-internal#1122](https://github.com/bitwarden/sdk-internal/pull/1122)) — blob-encrypted ciphers carry the name inside the sealed `data` blob rather than as a top-level field. `Cipher.toFailureCipherListView()` builds a `CipherListView` (whose `name` is non-null) directly from the encrypted `Cipher`, so the now-nullable `name` no longer compiles. This falls back to an empty string when the name is absent. The decrypted `CipherView` / `CipherListView` `name` fields are unchanged, so all UI and sorting is unaffected. > Pairs with the SDK version bump. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-06-12 05:23:58 -05:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#125631